Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnosing Serverless RU consumption #17826

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Diagnosing Serverless RU consumption #17826

merged 6 commits into from
Sep 27, 2023

Conversation

gemma-shay
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Files changed:

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 072b8e2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/65149b18cc2dfc000826ee15

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 072b8e2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/65149b1898320b0008336f1b

@netlify
Copy link

netlify bot commented Sep 7, 2023

Netlify Preview

Name Link
🔨 Latest commit 072b8e2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/65149b181e1e760008adb03c
😎 Deploy Preview https://deploy-preview-17826--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gemma-shay
Copy link
Contributor Author

@mdlinville @Amruta-Ranade could either of you give a docs review? trying to get this merged asap

@Amruta-Ranade
Copy link
Contributor

@mdlinville @Amruta-Ranade could either of you give a docs review? trying to get this merged asap

ah, thanks for the ping! looking at it now

@mdlinville
Copy link
Contributor

@mdlinville @Amruta-Ranade could either of you give a docs review? trying to get this merged asap

Happy to help if required!

src/current/cockroachcloud/serverless-resource-usage.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/serverless-resource-usage.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/serverless-resource-usage.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/serverless-resource-usage.md Outdated Show resolved Hide resolved

For information on planning your cluster configuration and setting resource limits, refer to [Plan a Serverless Cluster]({% link cockroachcloud/plan-your-cluster-serverless.md %}).

## Understand resource consumption in CockroachDB {{ site.data.products.serverless }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section feels disconnected from the rest of the doc since we don't refer to it anywhere else + feels distracting from what the user actually cares about (prescriptive and actionable guidance on diagnosing their RU usage). Let me know if I'm missing historical context on why this section is here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it's not a great fit, but it was already on this page and I think it's important context. I've been considering moving it to Plan Your Serverless Cluster but that page is also getting a bit long, especially with the multi-region additions i have to publish right after this. Do you think it should move there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR would like to move but don't have a better place in mind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it to the end of the doc? Let the user find the actionable guidance first and read additional material if they're interested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pushed an update. what do you think of this version with some prerequisite info at the top and the example RU calculation moved under the diagnostics?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in our 1:1, let's handle the info rearchitecture in a follow-up PR.

@gemma-shay gemma-shay enabled auto-merge (squash) September 27, 2023 21:13
@gemma-shay gemma-shay merged commit 3a408de into main Sep 27, 2023
@gemma-shay gemma-shay deleted the ru-diagnostic branch September 27, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants