Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate using Oracle GoldenGate #17769

Merged
merged 23 commits into from
Sep 29, 2023
Merged

Migrate using Oracle GoldenGate #17769

merged 23 commits into from
Sep 29, 2023

Conversation

gemma-shay
Copy link
Contributor

@github-actions
Copy link

Files changed:

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit de86412
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/651706cce7c4b000089a2768

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit de86412
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/651706ccaf6a7a00089409c7

@netlify
Copy link

netlify bot commented Aug 28, 2023

Netlify Preview

Name Link
🔨 Latest commit de86412
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/651706cb29fef400089ac0cd
😎 Deploy Preview https://deploy-preview-17769--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gemma-shay
Copy link
Contributor Author

Thanks @cotedm ! Incorporated your review and some other improvements. Going to tag in Ryan as well.

@gemma-shay gemma-shay requested a review from taroface September 5, 2023 21:33
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some bigger changes to the enumerated steps, because I think the snippets need to be more clearly segmented and explained based on the commands that are in them. This should require another tech review. Let me know if you have questions!

Also, I left comments on 23.1 but they apply to 23.2 of course.

src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Show resolved Hide resolved
@gemma-shay gemma-shay requested a review from taroface September 18, 2023 20:27
@gemma-shay gemma-shay enabled auto-merge (squash) September 18, 2023 20:28
@gemma-shay gemma-shay disabled auto-merge September 18, 2023 20:28
src/current/v23.1/goldengate.md Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.2/goldengate.md Show resolved Hide resolved
src/current/v23.1/goldengate.md Outdated Show resolved Hide resolved
src/current/v23.1/goldengate.md Show resolved Hide resolved
src/current/v23.1/goldengate.md Show resolved Hide resolved
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment! Thanks for all the work on this.

src/current/v23.1/goldengate.md Show resolved Hide resolved
@gemma-shay gemma-shay enabled auto-merge (squash) September 28, 2023 15:06
@gemma-shay gemma-shay requested a review from taroface September 28, 2023 15:07
@gemma-shay gemma-shay dismissed taroface’s stale review September 29, 2023 17:39

Addressed all comments

@gemma-shay gemma-shay merged commit f7daf59 into main Sep 29, 2023
3 checks passed
@gemma-shay gemma-shay deleted the migration-oracle branch September 29, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants