-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate using Oracle GoldenGate #17769
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @cotedm ! Incorporated your review and some other improvements. Going to tag in Ryan as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some bigger changes to the enumerated steps, because I think the snippets need to be more clearly segmented and explained based on the commands that are in them. This should require another tech review. Let me know if you have questions!
Also, I left comments on 23.1 but they apply to 23.2 of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 comment! Thanks for all the work on this.
https://cockroachlabs.atlassian.net/browse/DOC-8306