Skip to content

Commit

Permalink
Remove internal release note (#18000)
Browse files Browse the repository at this point in the history
  • Loading branch information
mdlinville authored Oct 19, 2023
1 parent 8e65f80 commit a2ad60b
Showing 1 changed file with 16 additions and 17 deletions.
33 changes: 16 additions & 17 deletions src/current/_includes/releases/v22.2/v22.2.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ Release Date: December 22, 2022
- Added the `sql.auth.change_own_password.enabled` [cluster setting](https://www.cockroachlabs.com/docs/v22.2/cluster-settings), which defaults to `false`. When set to `true`, any user is allowed to change their own password to a non-null value. Changing other [role options](https://www.cockroachlabs.com/docs/v22.2/security-reference/authorization#role-options) still has the same privilege requirements as before (either `CREATEROLE` or `CREATELOGIN`, depending on the option). [#90626][#90626]
- Added a new column `implicit_txn` (boolean) to [`crdb_internal.cluster_execution_insights`](https://www.cockroachlabs.com/docs/v22.2/crdb-internal#tables) and `crdb_internal.node_execution_insights`. [#90860][#90860]
- Previously, if a primary key name was a reserved SQL keyword, attempting to use the [`DROP CONSTRAINT, ADD CONSTRAINT`](https://www.cockroachlabs.com/docs/v22.2/alter-table#drop-and-add-a-primary-key-constraint) statements to change a primary key would result in a constraint already exists error. This is now fixed.[#90992][#90992]
- Currently the `AS OF SYSTEM TIME` value is set at the start of the TTL job (TTL cutoff - `30s`), but this results in an error similar to the following for TTL jobs that run longer than `gc.ttlseconds`:
- Currently the `AS OF SYSTEM TIME` value is set at the start of the TTL job (TTL cutoff - `30s`), but this results in an error similar to the following for TTL jobs that run longer than `gc.ttlseconds`:

~~~
error selecting rows to delete: ttl select defaultdb.public.events: batch timestamp 1666883527.780656000,0 must be after replica GC threshold 1666883574.542825089,0
error selecting rows to delete: ttl select defaultdb.public.events: batch timestamp 1666883527.780656000,0 must be after replica GC threshold 1666883574.542825089,0
~~~
Now, the `AS OF SYSTEM TIME` value is relative to when each `SELECT` query is run (query time - `30s`), which will prevent the error. However, each `SELECT` query will run against a different table state. If records are missed during one job invocation, they should still be picked up in the next. [#91111][#91111]
Expand All @@ -54,14 +54,13 @@ Release Date: December 22, 2022
<h3 id="v22-2-1-operational-changes">Operational changes</h3>
- Introduced a [cluster setting](https://www.cockroachlabs.com/docs/v22.2/cluster-settings) `kv.mvcc_gc.queue_interval` that controls how long the MVCC GC queue waits between processing replicas. It was previously hardcoded to `1s`, but is now configurable (`1s` continues to be the default value). Incidents were observed where a large volume of MVCC GC work can prove to be disruptive to foreground traffic. Previously, this GC work had been reduced in priority to make it less disruptive. This [cluster setting](https://www.cockroachlabs.com/docs/v22.2/cluster-settings) can serve as a manual form of pacing if the automatic approach proves insufficient. [#89423][#89423]
- Renamed the following [TTL metrics](https://www.cockroachlabs.com/docs/v22.2/row-level-ttl#ttl-metrics):
- `jobs.row_level_ttl.range_total_duration` to `jobs.row_level_ttl.span_total_duration`
- `jobs.row_level_ttl.num_active_ranges` to `jobs.row_level_ttl.num_active_spans`
- Renamed the following [TTL metrics](https://www.cockroachlabs.com/docs/v22.2/row-level-ttl#ttl-metrics):
- `jobs.row_level_ttl.range_total_duration` to `jobs.row_level_ttl.span_total_duration`
- `jobs.row_level_ttl.num_active_ranges` to `jobs.row_level_ttl.num_active_spans`
[#90359][#90359]
- The [cluster setting](https://www.cockroachlabs.com/docs/v22.2/cluster-settings) `kv.store.admission.provisioned_bandwidth` was renamed to `kvadmission.store.provisioned_bandwidth`. [#92439][#92439]
- Made the consistency check failure message more informative by suggesting a few actions that operatios should/could do in the event it occurs. [#90564][#90564]
- Logs produced by setting an increased `vmodule` setting for `s3_storage` are now directed to the `DEV` channel rather than `STDOUT`. [#89140][#89140]
- SQL tenants now support the HTTP endpoint under `/api/v2/sql`, which allows the caller to execute an HTTP request containing SQL statements to execute, and returns the results in the JSON response. This endpoint works identically as on a non-tenant server, except that it naturally scopes to the target tenant for SQL execution. [#91994][#91994]
- Introduced the metric `replicas.leaders_invalid_lease` that indicates how many replicas are raft group leaders, but holding invalid leases. [#91193][#91193]
<h3 id="v22-2-1-command-line-changes">Command-line changes</h3>
Expand Down Expand Up @@ -114,17 +113,17 @@ Release Date: December 22, 2022
- Fixed a bug that has existed in v21.1 and earlier that could cause an internal error when executing a query with a limit ordering on the output of a [window function](https://www.cockroachlabs.com/docs/v22.2/window-functions). [#87747][#87747]
- Fixed a longstanding bug that could cause a panic when running a query with [`EXPLAIN`](https://www.cockroachlabs.com/docs/v22.2/explain) that attempts to order on a non-output column. [#88687][#88687]
- Fixed a bug that could cause incorrect results in rare cases. The bug could only present if the following conditions were true:
1. A query with `ORDER BY` and `LIMIT` was executed.
2. The table containing the `ORDER BY` columns had an index containing those columns.
3. The index in (2) contained a prefix of columns held to a fixed number of values by the query filter (e.g., `WHERE a IN (1, 3)`), a `CHECK` constraint (e.g., `CHECK (a IN (1, 3))`), inferred by a computed column expression (e.g., `WHERE a IN (1, 3)` and a column `b INT AS (a + 10) STORED`), or inferred by a `PARTITION BY` clause (e.g., `INDEX (a, ...) PARTITION BY LIST (a) (PARTITION p VALUES ((1), (3)))`).
1. A query with `ORDER BY` and `LIMIT` was executed.
2. The table containing the `ORDER BY` columns had an index containing those columns.
3. The index in (2) contained a prefix of columns held to a fixed number of values by the query filter (e.g., `WHERE a IN (1, 3)`), a `CHECK` constraint (e.g., `CHECK (a IN (1, 3))`), inferred by a computed column expression (e.g., `WHERE a IN (1, 3)` and a column `b INT AS (a + 10) STORED`), or inferred by a `PARTITION BY` clause (e.g., `INDEX (a, ...) PARTITION BY LIST (a) (PARTITION p VALUES ((1), (3)))`).
This bug was present since version v22.1.0. [#89250][#89250]
- Previously, when writing storage checkpoints on consistency checker failures, flushing WAL was disabled, so some checkpoints could be slightly out of date. This is now fixed. [#89403][#89403]
- Adjusted [optimizer](https://www.cockroachlabs.com/docs/v22.2/cost-based-optimizer) selectivity and cost estimates of zigzag joins in order to prevent query plans from using it when it would perform poorly (when many rows are qualified). [#89427][#89427]
- Updated hot ranges, problem ranges, data distribution, stores report, range status, Raft for all ranges features to require `VIEWCLUSTERMETADATA`. Updated the [`SHOW CLUSTER SETTING`](https://www.cockroachlabs.com/docs/v22.2/show-cluster-setting) SQL command to require `VIEWCLUSTERSETTING/MODIFYCLUSTERSETTING` privileges. Fixed a visual bug on stores report where an error shows an infinite spinner only. [#89508][#89508]
- Fixed a bug introduced in v20.2 that could cause filters to be dropped from a query plan with many joins in rare cases. [#89158][#89158]
- Narrowed the conditions under which a `VOTER_DEMOTING_LEARNER` can acquire the lease in a joint configuration to:
a) There must be a `VOTER_INCOMING` in the configuration, and
b) The `VOTER_DEMOTING_LEARNER` was the last leaseholder.
a) There must be a `VOTER_INCOMING` in the configuration, and
b) The `VOTER_DEMOTING_LEARNER` was the last leaseholder.
This prevents it from acquiring the lease unless it is the only one that can acquire it. Transferring the lease away is necessary before exiting the joint configuration (without the fix the system can be stuck in a joint configuration in some rare situations). [#89594][#89594]
- Fixed tables created by [userfile storage](https://www.cockroachlabs.com/docs/v22.2/use-userfile-storage) that have invalid foreign key constraints. [#89371][#89371]
- Fixed a crash that could occur when dropping a role that owned two schemas with the same name in different databases. The bug was introduced in v22.1.0. [#89534][#89534]
Expand All @@ -133,11 +132,11 @@ This prevents it from acquiring the lease unless it is the only one that can acq
- Previously, uncommitted privileges could be cached if a transaction is rolled back. This is now fixed. This bug was only present in the v22.2 alpha and beta versions. Example:
~~~sql
BEGIN;
GRANT SELECT ON crdb_internal.tables TO testuser;
SELECT has_table_privilege('testuser', 'crdb_internal.tables', 'SELECT'); --- this caches the privilege ---
ROLLBACK; --- SELECT IS STILL CACHED UNTIL ANOTHER GRANT/REVOKE HAPPENS TO INVALIDATE THE CACHE---
~~~
BEGIN;
GRANT SELECT ON crdb_internal.tables TO testuser;
SELECT has_table_privilege('testuser', 'crdb_internal.tables', 'SELECT'); --- this caches the privilege ---
ROLLBACK; --- SELECT IS STILL CACHED UNTIL ANOTHER GRANT/REVOKE HAPPENS TO INVALIDATE THE CACHE---
~~~
[#89717][#89717]
Expand Down Expand Up @@ -165,7 +164,7 @@ This prevents it from acquiring the lease unless it is the only one that can acq
- Fixed a bug that could cause `SELECT *` operations on tables with [virtual computed columns](https://www.cockroachlabs.com/docs/v22.2/computed-columns) undergoing schema changes to potentially fail. [#91007][#91007]
- Fixed a bug where point lookups on the `pg_catalog.pg_type` table would fail to find the implicit record type that gets created for tables in the `pg_catalog`, `information_schema`, and `crdb_internal` schemas. [#91217][#91217]
- Fixed a bug that prevented the usage of implicit record types for tables in the `pg_catalog`, `information_schema`, and `crdb_internal` schemas. [#91217][#91217]
- Fixed a bug which caused a migration in v22.1 to fail to drop an index on the `system.statement_diagnostics_requests` table. This caused upgrades from v22.1 to v22.2, which had used the previous, faulty upgrade migration to now fail to create a new index with the same name, as the index was assumed to have been dropped previously. [#91308][#91308]
- Fixed a bug which caused a migration in v22.1 to fail to drop an index on the `system.statement_diagnostics_requests` table. This caused upgrades from v22.1 to v22.2, which had used the previous, faulty upgrade migration to now fail to create a new index with the same name, as the index was assumed to have been dropped previously. [#91308][#91308]
- A nil pointer crash that could be encountered when interleaving `SELECT FOR UPDATE SKIP LOCKED` statements has been resolved. [#91256][#91256]
- Fixed a bug present only in v22.2 release candidates, in which an [`ALTER PRIMARY KEY USING COLUMNS (x, x)`](https://www.cockroachlabs.com/docs/v22.2/alter-table#alter-primary-key) statement would result in an internal error instead of the expected user-facing error with a pg-code. [#91478][#91478]
- Fixed a bug in which panics triggered by certain DDL statements were not properly recovered, leading to the cluster node crashing. [#91552][#91552]
Expand Down

0 comments on commit a2ad60b

Please sign in to comment.