containers/ws: Fix build on Fedora 41 #21448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnf5 changed `--installroot` behaviour that it now only considers the repositories in the root instead of the host. This broke the container build. Unfortunately my fix for that [1] got lost in a git pilot failure, mea culpa! [1] cockpit-project#21360 (comment)
martinpitt
added
the
no-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dnf5 changed
--installrootbehaviour that it now only considers the repositories in the root instead of the host. This broke the container build.Unfortunately my fix for that [1] got lost in a git pilot failure, mea culpa!
[1] #21360 (comment)
See https://github.com/cockpit-project/cockpit/actions/workflows/build-ws-container.yml - after that lands, I'll do a hack to fix the container build for 331, as it now builds from the latest tag instead of main.
Tested locally with
podman build -t localhost/ws containers/ws