lib: Add types to pkg/lib/notifications #21445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
lib-type-notifications
branch
from
1635180 to
9f16dc4
Compare
mvollmer
changed the title
mvollmer
force-pushed
the
lib-type-notifications
branch
from
9f16dc4 to
78abdab
Compare
martinpitt
requested changes
Dec 18, 2024
mvollmer
force-pushed
the
lib-type-notifications
branch
from
78abdab to
34f1448
Compare
martinpitt
approved these changes
Dec 18, 2024
| @@ -27,8 +27,9 @@ import { SearchInput } from "@patternfly/react-core/dist/esm/components/SearchIn | |||
| import { Tooltip, TooltipPosition } from "@patternfly/react-core/dist/esm/components/Tooltip/index.js"; | |||
| import { ContainerNodeIcon, ExclamationCircleIcon, ExclamationTriangleIcon, InfoCircleIcon } from '@patternfly/react-icons'; | |||
|
|
|||
| import { Status } from "notifications"; | |||
There was a problem hiding this comment.
This is a case where import type is preferable, as notifications.tsx isn't otherwise used in the shell. However, we recently talked about that, and
NODE_ENV=development ./build.js shell
indeed confirms that pkg/lib/notifications.tsx does not land in the dist/shell/shell.js shell bundle. So tree shaking does work for pure .js/.ts, just not for anything with CSS.
It may still be a good habit to learn, to not unnecessarily blow up our bundles.
There was a problem hiding this comment.
Yes, good point! I didn't think of that.
cockpituous
reviewed
Dec 18, 2024
| // Generate name for the status | ||
| const desc_parts = name.toLowerCase().split(" "); | ||
| desc_parts.push(status.type); | ||
| desc_parts.push(status.type || ""); |
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.