Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Stop hardcoding libc soname #21431

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

martinpitt
Copy link
Member

ia64/alpha has SONAME "libc.so.6.1"

None works because Python is linked against libc, so the symbol is
already in our address space.

Fixes #21396


Plus, update ferny to pick up allisonkarlitskaya/ferny#32

This stops hardcoding the libc.so.6 soname, and has a new matcher for
OpenSSH 0.9.6's "hostname contains invalid characters" error.
ia64/alpha has SONAME "libc.so.6.1"

`None` works because Python is linked against libc, so the symbol is
already in our address space.

Fixes cockpit-project#21396
@martinpitt martinpitt marked this pull request as ready for review December 13, 2024 10:20
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! systemd-ctypes is all good?

(Assuming goes green)

@martinpitt
Copy link
Member Author

TIL!

me too!

systemd-ctypes is all good?

Yup, it only does ctypes.CDLL("libsystemd.so.0"), not libc

@martinpitt martinpitt merged commit 86b5a09 into cockpit-project:main Dec 13, 2024
87 checks passed
@martinpitt martinpitt deleted the alpha branch December 13, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testsuite fails on alpha due to incorrect filename for libc.so.6.1
2 participants