cockpit-ci: Update container to 2024-12-08 #21410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
allisonkarlitskaya
pushed a commit
that referenced
this pull request
Dec 9, 2024
allisonkarlitskaya
force-pushed
the
tasks-container-update-cockpit-ci-container-20241209-075211
branch
from
db1a8a3 to
e6af5d4
Compare
|
TODO:
|
martinpitt
pushed a commit
that referenced
this pull request
Dec 9, 2024
Adjust pixel tests for subtle font rendering changes with updated Chromium. Closes #21410
martinpitt
force-pushed
the
tasks-container-update-cockpit-ci-container-20241209-075211
branch
from
e6af5d4 to
d75bce9
Compare
martinpitt
pushed a commit
that referenced
this pull request
Dec 9, 2024
Adjust pixel tests for subtle font rendering changes with updated Chromium. Closes #21410
martinpitt
force-pushed
the
tasks-container-update-cockpit-ci-container-20241209-075211
branch
from
d75bce9 to
38603f5
Compare
12 tasks
|
This testPageStatus flake is a nuisance.. I threw an hour of attempted workarounds at it, but no joy. It would be really good to move Chromium to real mouse events.. |
martinpitt
pushed a commit
that referenced
this pull request
Dec 9, 2024
Adjust pixel tests for subtle font rendering changes with updated Chromium. Closes #21410
martinpitt
force-pushed
the
tasks-container-update-cockpit-ci-container-20241209-075211
branch
from
38603f5 to
afc2e19
Compare
Fixes RUF031 with ruff 0.6.7.
This should be obvious, but current mypy complains: > Need type annotation for "js_error_codes" [var-annotated]
Fixes ruff I001 with ruff 0.6.7.
> Using `yield` and `return {value}` in a generator function can lead to
confusing behavior
But that's the expected GeneratorChannel API (it looks at
`StopIteration.value`), and also tricky to avoid.
A005 Module `http` is shadowing a Python builtin module
Precisely type the various `tag_from_*()` helpers and the `_tag` member variable. Fix return type of `set_contents()` -- `tag_from_path()` can return None, so this function can, too. Fixes error with mypy 1.13.0: > Incompatible types in assignment (expression has type "Any | str", variable has type "None") [assignment]
The error name changed: > No overload variant of "open" matches argument types "GzipFile", "str", "bool" [call-overload] So accept both the old and new spelling for the time being.
Fixes lots of complaints with ruff 0.8 like > RUF039 First argument to `re.match()` is not raw string
Fixes lots of issues with ruff 0.8: > RUF052 [*] Local dummy variable `_msg` is accessed This is right -- all these `_msg` are actually being used. Use `type_` and `class_`, follow ruff's recommendation: > help: Prefer using trailing underscores to avoid shadowing a built-in
Our synthetic mouse events on latest Chromium 131 are sometimes missed. It works reliably with TEST_SHOW_BROWSER and with the real mouse events in Firefox. Given the resounding silence of our other chromium bug reports, let's just skip that test there.
TestHostSwitching.testBasic does pixel tests of the host selector menu, which is the top left element at position (0, 0). Current Chromium changes behaviour to always focus that element, and it's fairly stubborn. To avoid pixel testing the focused (light-gray) variant, move the mouse away first.
martinpitt
pushed a commit
that referenced
this pull request
Dec 9, 2024
Adjust pixel tests for subtle font rendering changes with updated Chromium. Closes #21410
martinpitt
force-pushed
the
tasks-container-update-cockpit-ci-container-20241209-075211
branch
from
afc2e19 to
0c4755e
Compare
|
Dang, this 1-pixel diff is also real, new browser.. Updating. |
jelly
previously approved these changes
Dec 9, 2024
| @@ -183,6 +183,14 @@ class TestHostSwitching(testlib.MachineCase, HostSwitcherHelpers): | |||
| b.wait_not_present("#nav-system.interact") | |||
| b.set_layout("desktop") | |||
|
|
|||
| # this looks different (focused) when the mouse is inside (default 0,0 possition), so move it away | |||
| # chromium is stubborn here, we *have* to move the real mouse, not just do this with synthetic MouseEvents | |||
| b.bidi("input.performActions", context=b.driver.context, actions=[{ | |||
There was a problem hiding this comment.
Only affects chrome, then we could gate it? But lets get CI green again
There was a problem hiding this comment.
I could make it conditional on .browser == chromium, but we don't run pixel tests on Firefox anyway, so it's no practical difference.
Adjust pixel tests for subtle font rendering changes with updated Chromium. Closes #21410
martinpitt
force-pushed
the
tasks-container-update-cockpit-ci-container-20241209-075211
branch
from
0c4755e to
16e7ee0
Compare
jelly
approved these changes
Dec 10, 2024
martinpitt
deleted the
tasks-container-update-cockpit-ci-container-20241209-075211
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.