Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck javascript #21377

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Typecheck javascript #21377

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed3a3ce
test: check JavaScript files with TypeScript in typecheck
jelly Dec 3, 2024
a97c5e7
storaged: fix typo'd page_category
jelly Dec 3, 2024
d0538a8
test: fail typecheck on ignored but unused typescript erors
jelly Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/storaged/iscsi/session.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function make_iscsi_session_page(parent, session) {
page_location: ["iscsi", session.data.target_name],
page_name: session.data.target_name,
page_icon: NetworkIcon,
page_categroy: PAGE_CATEGORY_NETWORK,
page_category: PAGE_CATEGORY_NETWORK,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

component: ISCSISessionCard,
props: { session },
actions: [
Expand Down
1 change: 0 additions & 1 deletion test/typecheck
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ javascript_ignored_codes = [
"TS2349", # This expression is not callable.
"TS1345", # An expression of type 'void' cannot be tested for truthiness.
"TS2693", # 'X' only refers to a type
"TS2561", # Object literal may only specify known properties, but 'page_categroy' does not exist in type
"TS2554", # Expected 0 arguments, but got 1.
"TS2810", # Expected 1 argument, but got 0.
"TS2550", # Property 'replaceAll' does not exist on type 'string'.
Expand Down
Loading