Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Run trigger-anaconda in our tasks container #20477

Closed
wants to merge 1 commit into from
Closed

workflows: Run trigger-anaconda in our tasks container #20477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/trigger-anaconda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,18 @@ jobs:
permissions:
contents: read
statuses: write
container: registry.fedoraproject.org/fedora:rawhide
container:
image: ghcr.io/cockpit-project/tasks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a more usual stable fedora image like 40?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! My impression was that we are moving towards running as much as possible inside our task container, so that we need to worry about as few containers as possible. And this workflow calls bots/tests-trigger, and our task container is meant to execute bots code like this, no?

So, my impression is task-container == some stable thing plus dependencies required by our bots. Is that not so?

Copy link
Member

@allisonkarlitskaya allisonkarlitskaya May 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to run this in the tasks container, then I feel like we should make sure we already have the dependencies that this thing needs present in the tasks container.

So like:

  • use tasks container; or
  • standard image + dnf install some stuff

pick one.

Downloading the much larger image and having to do dnf anyway seems like a real waste of time...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright: #20478

options: --user root
# this polls for a COPR build, which can take long
timeout-minutes: 120

steps:
- name: Install dependencies
run: |
dnf install -y git-core dnf5-plugins || {
dnf install -y git-core dnf-plugins-core || {
sleep 60
dnf install -y git-core dnf5-plugins
dnf install -y git-core dnf-plugins-core
}

# Naïvely this should wait for github.event.pull_request.head.sha, but
Expand Down
Loading