fmf: Uninstall cockpit-packagekit for basic and network plans #19556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
release-blocker
|
It makes downstream gating tests green, but one regression in testCPUSecurityMitigationsDetect which is easy to fix. Update: On closer look it actually is a bit tricky: |
martinpitt
removed
the
no-test
martinpitt
force-pushed
the
fmf-no-weak
branch
from
0ee0dc7 to
b0c559f
Compare
These are the only tests that need the `PackageCase` API. This split makes it possible to run the other TestSystemInfo tests on a machine which does not have cockpit-packagekit/PackageKit installed. Rename the pixel references accordingly.
These plans are not meant to have cockpit-packagekit installed. That isn't in the test dependency list, but dnf installs "missing" weak dependencies on upgrades by default, which is undesired: The packagekit page gets preloaded and thus influences the test outcome, particularly when it is an old version (as happens during downstream gating). So remove the package again if it got installed for plans other than "optional" (which is the one that actually tests packagekit). Fixes https://gitlab.com/redhat/centos-stream/rpms/cockpit/-/merge_requests/68
martinpitt
force-pushed
the
fmf-no-weak
branch
from
b0c559f to
8651dc0
Compare
|
Interesting, this c9s TF failure is the same that I got in https://gitlab.com/redhat/centos-stream/rpms/cockpit/-/merge_requests/67 . So that's a flake, not a failure. |
KKoukiou
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These plans are not meant to have cockpit-packagekit installed. That isn't in the test dependency list, but dnf installs "missing" weak dependencies on upgrades by default, which is undesired: The packagekit page gets preloaded and thus influences the test outcome, particularly when it is an old version (as happens during downstream gating).
So remove the package again if it got installed for plans other than "optional" (which is the one that actually tests packagekit).
Fixes https://gitlab.com/redhat/centos-stream/rpms/cockpit/-/merge_requests/68
See the link, this breaks the downstream release. I ran the tests against this branch to confirm that it fixes it.
This is essentially the same approach as in e.g. cockpit-project/cockpit-machines@430b819 or cockpit-project/cockpit-podman@99efdb6 , which work around the same dnf misfeature.