Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmf: Fix COPR yum repo globbing #19552

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Nov 1, 2023

Commit 7ab102a inexplicably slipped in a : which is not actually part of the downloaded file name. This breaks the globbing.


See most recent failure in fedora-selinux/selinux-policy#1913 . I can't say anything else than "sorry!" and "no idea".. I did test the commands in a container, not sure where it went wrong.

/me draws a penalty card ♣️

Commit 7ab102a inexplicably slipped in a `:` which is not actually
part of the downloaded file name. This breaks the globbing.
@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Nov 1, 2023
@martinpitt
Copy link
Member Author

podman run -it --rm registry.fedoraproject.org/fedora:rawhide
env releasever=rawhide curl --output /etc/yum.repos.d/group_cockpit-main-builds-fedora-$releasever.repo.repo -LO https://copr.fedorainfracloud.org/coprs/g/cockpit/main-builds/repo/fedora-$releasever/group_cockpit-main-builds-fedora-$releasever.repo

dnf install -y cockpit-system
# installs  303-2.fc40

set -x
main_builds_repo="$(ls /etc/yum.repos.d/*cockpit*main-builds* 2>/dev/null || true)"    
if [ -n "$main_builds_repo" ]; then    
    echo 'priority=0' >> "$main_builds_repo"    
    dnf distro-sync -y 'cockpit*'    
fi    
+ '[' -n /etc/yum.repos.d/group_cockpit-main-builds-fedora-.repo.repo ']'
# ... installs cockpit-system-303-1.20231031153519113467.main.66.g7ab102a55.fc40.noarch

@martinpitt martinpitt merged commit 44baede into cockpit-project:main Nov 1, 2023
36 checks passed
@martinpitt martinpitt deleted the typo branch November 1, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants