Fix invalid property types #19505
Merged
Fix invalid property types #19505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
the
no-test
martinpitt
force-pushed
the
prop-types
branch
from
2d21ac9 to
e634b41
Compare
martinpitt
removed
the
no-test
martinpitt
force-pushed
the
prop-types
branch
from
e634b41 to
a4352b0
Compare
In `Dialog`, the `error` property is always a string, as `show_modal_dialog()`'s `set_error` call already stringifies objects. Hence they can never actually have a `.details` field, and our code also does not set this anywhere. This fixes a lot of property type warnings.
martinpitt
force-pushed
the
prop-types
branch
from
a4352b0 to
cedf22e
Compare
jelly
requested changes
Oct 19, 2023
martinpitt
force-pushed
the
prop-types
branch
from
cedf22e to
3f6004a
Compare
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Dialog.title must be a `string`. PatternFly's modal has a `titleIconVariant` property for this use case, which is exposed by our Dialog component. Use that instead. Adjust the pixel references for the slightly changed title layout.
The previous commits fix all of them.
|
This slightly changes the dialog, pushed updated pixels. |
martinpitt
force-pushed
the
prop-types
branch
from
3f6004a to
60e36c6
Compare
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
jelly
approved these changes
Oct 19, 2023
mvollmer
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.