React warning fixes #19503
Merged
React warning fixes #19503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passwd, and thus the accounts list can have duplicate UIDs, with different user names. TestAccounts.testCustomUID covers that case. Avoid this by consitently using user and group names, as the other places of the code already do.
This property can specify a custom failure message, but there's a default one. The SELinux page uses the default.
The property is required, and from the component's PoV that is right as it gets called unconditionally. In the host selector we don't use jumps/links, but React's property check cannot know that. To quiesce these warnings, add a dummy jump property to the host selector instantiation.
|
Oh, this failure is interesting: I reported this a https://issues.redhat.com/browse/RHEL-14082 , this should become a naughty. The other failures are easy, fixed. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
one more common tracer exit which we should ignore. Same thing here. |
martinpitt
added
the
blocked
ModuleNotFoundError happens every time on every non-Fedora OS, and there are common problem codes which don't need to make noise.
|
We should ignore UnsupportedDistribution as well |
|
Meh, one more tracer bug on RHEL 9.3 and RHEL 9.4: I reported this to https://issues.redhat.com/browse/RHEL-14094 , will add naughty. |
martinpitt
removed
the
blocked
|
The accounts tests are very flaky with 3x affected retries, but the remaining ones are unrelated to the changes here. @jelly perhaps you can hit the retry button later tonight, as I'll be AFK for a while. |
cockpituous
reviewed
Oct 18, 2023
| exception.problem !== "access-denied" && | ||
| // or the session goes away while checking | ||
| exception.problem !== "terminated") | ||
| console.error(`Tracer failed: "${JSON.stringify(exception)}", data: "${JSON.stringify(data)}"`); |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| sorting={(a, b) => true} | ||
| filtering={this.filterHosts} | ||
| current={label} | ||
| jump={() => console.error("internal error: jump not supported in hosts selector")} |
There was a problem hiding this comment.
This added line is not executed by any test. Details
jelly
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First wave of fixes after #19053