Add some aria-labels #19496
Closed
Add some aria-labels #19496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
@garrett Do any of these seem useful for you? If not, I'm happy to toss this away, and we ignore the React warnings for the time being. |
|
The anaconda failure happens elsewhere too, this is on anaconda's main already. |
|
"don't care" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from @jelly 's PR #19053 after rebasing, and vetting whether an aria-label actually makes sense. E.g. this commit seems redundant to me, as it already has an
aria-labelledby, and I'm not sure about this one. But these four seem good fixes.