test: Fix pytest race in test_spawn_broken_pipe() #19470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
the
no-test
martinpitt
removed
the
no-test
martinpitt
force-pushed
the
spawn-test
branch
from
cf579e4 to
3b2e5ad
Compare
|
(I realized I don't actually want no-test, as this test runs during rpm/deb package builds) |
allisonkarlitskaya
previously approved these changes
Oct 12, 2023
| with open(f'/proc/{pid}/stat') as f: | ||
| if f.read().split()[2] == 'Z': | ||
| break | ||
| time.sleep(0.1) |
There was a problem hiding this comment.
I'm generally okay with this approach, but you could also do something like:
# The process will exit soon — try writing to it until a write fails.
# Note: it's important that we observe .write() failing, so we do sync
# sleep to avoid being notified about the process exiting.
while not transport.is_closing():
transport.write(b'x')
time.sleep(0.1)no?
There was a problem hiding this comment.
Ah, nice idea -- catch it from the write side instead of the process exit side. Seems to work fine!
|
Interesting: we thought long and hard about the race failing when the process exited too quickly (before the registration of the exit handler) but never considered the other direction :) |
The static `time.sleep(0.1)` was racy: On slow architectures like Debian mips [1] it repeatedly fails, and it even sometimes fails on GitHub actions. Keep writing until the transport closes, so that we are guaranteed to eventually run into a BrokenPipeError. Fixes cockpit-project#19469 [1] https://buildd.debian.org/status/logs.php?pkg=cockpit&ver=302-1&arch=mips64el
martinpitt
force-pushed
the
spawn-test
branch
from
3b2e5ad to
934c61c
Compare
allisonkarlitskaya
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static
time.sleep(0.1)was racy: On slow architectures like Debian mips [1] it repeatedly fails, and it even sometimes fails on GitHub actions.Keep writing until the transport closes, so that we are guaranteed to eventually run into a BrokenPipeError.
Fixes #19469
[1] https://buildd.debian.org/status/logs.php?pkg=cockpit&ver=302-1&arch=mips64el
Failures on GitHub: example 1, example 2