Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Drop unused cssnano-preset-lite, fix stylelint errors on main #19429

Merged
merged 2 commits into from
Oct 4, 2023
Merged

package.json: Drop unused cssnano-preset-lite, fix stylelint errors on main #19429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c6885b
package.json: Drop unused cssnano-preset-lite
martinpitt Oct 4, 2023
bdda36e
stylelint: Adjust rules to stylelint 15
martinpitt Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .stylelintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
"stylelint-use-logical-spec"
],
"rules": {
"indentation": 2,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems suspicious? Why is it dropped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stylelint.io/migration-guide/to-15 and https://stylelint.io/user-guide/rules/indentation/ just say that it's deprecated, but not why 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, well as the default is 2 anyway. LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that could be? They want to stop supporting anything else than 2?

"declaration-colon-newline-after": null,
"selector-list-comma-newline-after": null,

Expand All @@ -26,6 +24,7 @@
"function-url-quotes": null,
"keyframes-name-pattern": null,
"max-line-length": null,
"media-feature-range-notation": "prefix",
"no-descending-specificity": null,
"no-duplicate-selectors": null,
"scss/at-extend-no-missing-placeholder": null,
Expand All @@ -38,6 +37,7 @@
"scss/operator-no-unspaced": null,
"selector-class-pattern": null,
"selector-id-pattern": null,
"selector-not-notation": "simple",
"liberty/use-logical-spec": "always"
}
}
2 changes: 1 addition & 1 deletion node_modules
Open in desktop
Submodule node_modules updated 33 files
+0 −69 .package-lock.json
+0 −1 .package.json
+0 −48 cssnano-preset-lite/CHANGELOG.md
+0 −100 cssnano-preset-lite/README.md
+0 −28 cssnano-preset-lite/dist/index.js
+0 −37 cssnano-preset-lite/package.json
+0 −51 cssnano-utils/CHANGELOG.md
+0 −16 cssnano-utils/README.md
+0 −20 cssnano-utils/dist/getArguments.js
+0 −22 cssnano-utils/dist/getMatch.js
+0 −39 cssnano-utils/dist/index.js
+0 −36 cssnano-utils/dist/rawCache.js
+0 −47 cssnano-utils/dist/sameParent.js
+0 −30 cssnano-utils/package.json
+0 −22 postcss-discard-comments/LICENSE-MIT
+0 −114 postcss-discard-comments/README.md
+0 −38 postcss-discard-comments/package.json
+0 −153 postcss-discard-comments/src/index.js
+0 −31 postcss-discard-comments/src/lib/commentParser.js
+0 −32 postcss-discard-comments/src/lib/commentRemover.js
+0 −21 postcss-discard-comments/types/index.d.ts
+0 −2 postcss-discard-comments/types/lib/commentParser.d.ts
+0 −14 postcss-discard-comments/types/lib/commentRemover.d.ts
+0 −22 postcss-discard-empty/LICENSE-MIT
+0 −49 postcss-discard-empty/README.md
+0 −42 postcss-discard-empty/package.json
+0 −57 postcss-discard-empty/src/index.js
+0 −9 postcss-discard-empty/types/index.d.ts
+0 −22 postcss-normalize-whitespace/LICENSE-MIT
+0 −44 postcss-normalize-whitespace/README.md
+0 −41 postcss-normalize-whitespace/package.json
+0 −108 postcss-normalize-whitespace/src/index.js
+0 −9 postcss-normalize-whitespace/types/index.d.ts
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"argparse": "2.0.1",
"axe-core": "3.5.2",
"chrome-remote-interface": "0.32.1",
"cssnano-preset-lite": "2.0.1",
"esbuild": "0.19.4",
"esbuild-plugin-copy": "2.1.1",
"esbuild-plugin-replace": "1.4.0",
Expand Down