storage: Don't allow mounting over other mounted filesystems #19388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, nice coverage report, very accurate! |
mvollmer
force-pushed
the
storage-no-overmounting
branch
4 times, most recently
from
360ec0b to
0731117
Compare
mvollmer
force-pushed
the
storage-no-overmounting
branch
from
0731117 to
60b44b5
Compare
mvollmer
added
the
blocked
mvollmer
force-pushed
the
storage-no-overmounting
branch
from
60b44b5 to
49dc2a8
Compare
mvollmer
removed
the
blocked
mvollmer
commented
Sep 28, 2023
Comment on lines
+795
to
+798
| if (u.usage == 'mounted' && u.location == location) { | ||
| if (is_top) { | ||
| u.actions = get_actions(_("unmount")); | ||
| u.set_noauto = false; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mvollmer
force-pushed
the
storage-no-overmounting
branch
2 times, most recently
from
963df5d to
b2b52bd
Compare
mvollmer
force-pushed
the
storage-no-overmounting
branch
2 times, most recently
from
ddd3daa to
f2fde63
Compare
mvollmer
force-pushed
the
storage-no-overmounting
branch
from
64a9fe0 to
8fd9cae
Compare
mvollmer
force-pushed
the
storage-no-overmounting
branch
2 times, most recently
from
6b3322b to
e3e3b90
Compare
jelly
reviewed
Oct 2, 2023
mvollmer
force-pushed
the
storage-no-overmounting
branch
from
e3e3b90 to
f2b455b
Compare
jelly
previously approved these changes
Oct 3, 2023
| @@ -828,7 +872,8 @@ export function get_active_usage(client, path, top_action, child_action) { | |||
| return usage; | |||
| } | |||
|
|
|||
| let usage = get_usage(path, 0); | |||
| let usage = []; | |||
| get_usage(usage, path, 0); | |||
There was a problem hiding this comment.
Can't say I am super big fan of the indirection of filling in usage.
There was a problem hiding this comment.
Immutable data structures are overrated. :-)
And unmount nested filesystems during teardown.
Just janking out the disk will leave debris behind in /dev.
We still want to check whether it is unique etc.
mvollmer
force-pushed
the
storage-no-overmounting
branch
from
f2b455b to
0407a6e
Compare
cockpituous
reviewed
Oct 4, 2023
Comment on lines
+1198
to
+1201
| } else if (n_processes > 0) { | ||
| return _("Related processes will be forcefully stopped."); | ||
| } else if (n_services > 0) { | ||
| return _("Related services will be forcefully stopped."); |
There was a problem hiding this comment.
These 4 added lines are not executed by any test. Details
jelly
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://www.youtube.com/watch?v=tnf3Wl--Duw