pf: Fix double-spacing issue for other dropdowns as well

As seen on the help and session menus in the shell and possibly elsewhere.
cockpit-project · Apr 25, 2024 · d39255f · d39255f
1 parent 6ed0f6c
commit d39255f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/lib/patternfly/patternfly-5-overrides.scss b/pkg/lib/patternfly/patternfly-5-overrides.scss
@@ -81,6 +81,12 @@ select.pf-v5-c-form-control {
   margin: 0;
 }
 
+// Fix the double-spacing issue for other dropdowns
+// https://github.com/patternfly/patternfly-react/issues/10302
+.pf-v5-c-menu-toggle__controls:last-child > .pf-v5-c-menu-toggle__toggle-icon {
+  margin-inline-end: 0;
+}
+
 // The default gap between the rows in horizontal lists is too large
 .pf-v5-c-description-list.pf-m-horizontal-on-sm,
 .pf-v5-c-description-list.pf-m-horizontal {

diff --git a/test/reference b/test/reference
+ −		TestSuperuser-testBasic-topnav-privileged-dark-pixels.png
+ −		TestSuperuser-testBasic-topnav-privileged-medium-pixels.png
+ −		TestSuperuser-testBasic-topnav-privileged-pixels.png
+ −		TestSuperuser-testBasic-topnav-privileged-rtl-pixels.png
+ −		TestSuperuser-testBasic-topnav-unprivileged-dark-pixels.png
+ −		TestSuperuser-testBasic-topnav-unprivileged-medium-pixels.png
+ −		TestSuperuser-testBasic-topnav-unprivileged-pixels.png
+ −		TestSuperuser-testBasic-topnav-unprivileged-rtl-pixels.png
+ −		TestSystemInfo-testBasic-overview-dark-pixels.png
+ −		TestSystemInfo-testBasic-overview-medium-pixels.png
+ −		TestSystemInfo-testBasic-overview-mobile-pixels.png
+ −		TestSystemInfo-testBasic-overview-pixels.png
+ −		TestSystemInfo-testBasic-overview-rtl-pixels.png