Skip to content

Commit

Permalink
pf: Fix menu items cropping their content
Browse files Browse the repository at this point in the history 
Fixes #20340
  • Loading branch information
@garrett @jelly
garrett authored and jelly committed Apr 25, 2024
1 parent b726844 commit 3a998b0
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/lib/patternfly/patternfly-5-overrides.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ select.pf-v5-c-form-control {
margin-inline-end: 0;
}

// Fix menus cropping contents
// https://github.com/patternfly/patternfly/issues/6565
.pf-v5-c-menu__item-text {
overflow: visible;
}

// The default gap between the rows in horizontal lists is too large
.pf-v5-c-description-list.pf-m-horizontal-on-sm,
.pf-v5-c-description-list.pf-m-horizontal {
Expand Down

1 comment on commit 3a998b0

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your Packit configuration the settings of the @cockpit/cockpit-preview Copr project would need to be updated as follows:

field old value new value
chroots ['centos-stream-9-x86_64', 'epel-9-x86_64', 'epel-9-aarch64', 'centos-stream-9-aarch64'] ['centos-stream-8-x86_64', 'centos-stream-9-aarch64', 'centos-stream-9-x86_64', 'epel-8-aarch64', 'epel-8-x86_64', 'epel-9-aarch64', 'epel-9-x86_64']

Diff of chroots:

+epel-8-aarch64
+epel-8-x86_64
+centos-stream-8-x86_64

Packit was unable to update the settings above as it is missing admin permissions on the @cockpit/cockpit-preview Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the @cockpit/cockpit-preview Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

Please sign in to comment.