Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email invoice trigger #88

Merged
merged 9 commits into from
May 6, 2024
Merged

Add email invoice trigger #88

merged 9 commits into from
May 6, 2024

Conversation

Jsnxyz
Copy link
Contributor

@Jsnxyz Jsnxyz commented Apr 29, 2024

Added membership email to invoice trigger output

Fixes #87

@Jsnxyz Jsnxyz requested a review from langalex April 29, 2024 11:56
src/test/triggers/triggerInvoiceCreated.test.ts Outdated Show resolved Hide resolved
src/types/api-responses.d.ts Outdated Show resolved Hide resolved
src/utils/api.ts Outdated Show resolved Hide resolved
src/types/api-responses.d.ts Outdated Show resolved Hide resolved
src/utils/api.ts Outdated Show resolved Hide resolved
src/utils/api.ts Outdated Show resolved Hide resolved
@Jsnxyz Jsnxyz requested a review from langalex May 2, 2024 16:35
src/test/triggers/triggerInvoiceCreated.test.ts Outdated Show resolved Hide resolved
src/triggers/triggerInvoiceCreated.ts Show resolved Hide resolved
src/utils/api.ts Outdated
@@ -166,6 +167,25 @@ export const listRecentInvoices = async (
return response.data.data;
};

export const loadMembershipEmailOnInvoice = async (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you clean this up a bit? all (other) functions in this file return api responses. the conversion from api response to output happen in api-to-output.ts

src/utils/api.ts Outdated
@@ -166,6 +167,25 @@ export const listRecentInvoices = async (
return response.data.data;
};

export const loadMembershipEmailOnInvoice = async (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const loadMembershipEmailOnInvoice = async (
export const getMembership = async (

@Jsnxyz Jsnxyz requested a review from langalex May 6, 2024 13:25
@Jsnxyz Jsnxyz merged commit 742dbf7 into main May 6, 2024
4 checks passed
@Jsnxyz Jsnxyz deleted the add-email-invoice-trigger branch May 6, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add membership email to new invoice data
2 participants