Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make any_field_blank optional #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lampslave
Copy link

No description provided.

@GeyseR
Copy link
Collaborator

GeyseR commented Nov 3, 2016

Hi, @lampslave!
Why do we need such global setting? I guess empty values in blank fields shouldn't break tests.

@lampslave
Copy link
Author

Hi @GeyseR
Sadly, they do it after #47 :( For example: user has optional field email, we send some notifications and want to check mail.outbox. To fix it I need to specify email every time. Sometimes it can be awful: order__manager__user__email=.... Random makes debugging much harder.

@GeyseR
Copy link
Collaborator

GeyseR commented Nov 3, 2016

Hi, @lampslave.

Thanks for info, some notes/questions:

To fix it I need to specify email every time

i think it's ok to do that, because your tests are based on email

order__manager__user__email

do you really have email field with allowed blank values?

@lampslave
Copy link
Author

Basically it's good, but not for large amount of legacy code.

Yes, and you know about it even more than I do ;) Empty emails, phones, second/last names and so on.

@lampslave lampslave force-pushed the optional_any_field_blank branch from ac4a58e to 261d25b Compare April 15, 2019 07:20
@lampslave lampslave force-pushed the optional_any_field_blank branch from 261d25b to 784bef3 Compare April 17, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants