Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy-paste error in Ardulink init #472

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix copy-paste error in Ardulink init #472

merged 1 commit into from
Dec 9, 2024

Conversation

maxgerhardt
Copy link
Contributor

@maxgerhardt maxgerhardt commented Dec 7, 2024 •
edited
Loading

Discovered by @monte-monte in master...monte-monte:ch32v003fun:usb_terminal, looks like a clear bug.

Used when explicitly giving ./minichlink -C arduilink

@TommyMurphyTM1234
Copy link
Contributor

TommyMurphyTM1234 commented Dec 7, 2024 •
edited
Loading

Yes, I had previously asked about this issue here:

Does -C ardulink make any difference?
...
Although, even if it should work, this looks odd - why TryInit_B003Fun() instead of TryInit_Ardulink() for the Ardulink case?

@TommyMurphyTM1234 TommyMurphyTM1234 mentioned this pull request Dec 7, 2024
Open
@cnlohr cnlohr merged commit 9a305d8 into cnlohr:master Dec 9, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxgerhardt @TommyMurphyTM1234 @cnlohr