Fix unitialized WCH-LinkE errors #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnlohr
reviewed
Nov 26, 2024
| int i; | ||
| for( i = 0; i < transferred; i++ ) | ||
| struct InternalState *iss = (struct InternalState *)( ( (struct ProgrammerStructBase *)dev )->internal ); | ||
| if ( !iss->target_chip_id && !iss->statetag ) |
There was a problem hiding this comment.
statetag doesn't mean anything here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LE read or write command fails check internal state of programmer and chip id to determine if programmer was initialized in this run. If not, send magic command in hope to fix things. Works when you just plugged WCH-LinkE into the USB and running minichlink with command that skips startup.