Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linker related error. #297

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix linker related error. #297

merged 2 commits into from
Apr 3, 2024

Conversation

imbus64
Copy link

@imbus64 imbus64 commented Mar 31, 2024

These patches fixes a linker issue where the .note.gnu.build-id would corrupt the binary. Some other commonly discarded sections are also thrown in, some of which have a measurable effect on the final binary. The pre-built binary present in the blink example directory was also removed.

@cnlohr
Copy link
Owner

cnlohr commented Apr 3, 2024

@imbus64 do not delete the .bin. It is there on purpose so people can flash it, I want the rest of the PR. Please update.

@imbus64
Copy link
Author

imbus64 commented Apr 3, 2024

@imbus64 Done.

@cnlohr cnlohr merged commit 7b87b3f into cnlohr:master Apr 3, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants