Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation for arch linux #259

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

amitesh-singh
Copy link
Contributor

on arch linux, the risc compiler name is different. Add some logic to pick correct risc compiler on arch linux

@cnlohr
Copy link
Owner

cnlohr commented Dec 23, 2023

Can you change it so you test if the typical compiler exists, else use a different one? I.e.

https://stackoverflow.com/a/25668869/2926815

When not on Windows (Windows doesn't have which)

@cnlohr
Copy link
Owner

cnlohr commented Feb 2, 2024

poke @amitesh-singh Any chance you could update this to do the check for the if-exists?

@amitesh-singh amitesh-singh force-pushed the ami/fix_arch_compilation branch 3 times, most recently from 1d328da to a569ea9 Compare February 3, 2024 08:31
@amitesh-singh
Copy link
Contributor Author

@cnlohr updated. Thanks for the reminder.

@amitesh-singh amitesh-singh force-pushed the ami/fix_arch_compilation branch 2 times, most recently from b54e24b to ed35160 Compare February 3, 2024 08:48
on arch linux, the risc compiler name is different.
Add some logic to pick correct risc compiler on arch linux

Signed-off-by: Amitesh Singh <[email protected]>
@amitesh-singh amitesh-singh force-pushed the ami/fix_arch_compilation branch from ed35160 to c90a5c7 Compare February 4, 2024 16:41
@cnlohr cnlohr merged commit 45af736 into cnlohr:master Feb 5, 2024
51 checks passed
@cnlohr
Copy link
Owner

cnlohr commented Feb 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants