Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standby examples and add implementation notes. #235

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

baoshi
Copy link
Contributor

@baoshi baoshi commented Sep 8, 2023

Set GPIOs to input pull-up/pull-down is required to achieve 10uA standby current. Update examples and added notes.

@cnlohr
Copy link
Owner

cnlohr commented Sep 18, 2023

Really like some of these changes, especially the documentation ones, but, using large streams of binary digits is a recipe to confuse people, please use more of the defines from ch32v003fun.

@marekmaskarinec
Copy link
Contributor

Maybe this level of documentation could be the standard for all examples.

@baoshi
Copy link
Contributor Author

baoshi commented Sep 23, 2023

Have relooked into the standby current and found my previous result not entirely correct. Have updated GPIO configuration notes and examples accordingly.

@cnlohr
Copy link
Owner

cnlohr commented Sep 24, 2023

Looks pretty good now.

@cnlohr cnlohr merged commit 42cb809 into cnlohr:master Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants