Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MAX7219 SPI display driver library + example and small SPI library fixes #153

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add MAX7219 SPI display driver library + example and small SPI library fixes #153

merged 1 commit into from
Oct 4, 2023

Conversation

alexhorner
Copy link
Contributor

No description provided.

@alexhorner alexhorner mentioned this pull request Jun 23, 2023
Closed
@cnlohr
Copy link
Owner

cnlohr commented Jun 28, 2023

@alexhorner could you rebase this off of current master? And add an appropriate funconfig.h

Also, can you move your MAX7219 specific "extralib" into the max7219 folder?

After that, I believe I am up for accepting the PR.

@cnlohr
Copy link
Owner

cnlohr commented Jul 31, 2023

After much deliberation, I have decided to decline this PR.

I would rather not include drivers for other specific devices like this moving forward. Please see https://github.com/recallmenot/ch32v003fun_wildwest and https://github.com/hexeguitar/ch32v003fun_libs for avenues forward here.

Sorry about this.

@cnlohr cnlohr closed this Jul 31, 2023
@cnlohr cnlohr reopened this Oct 4, 2023
@alexhorner alexhorner marked this pull request as draft October 4, 2023 18:38
@alexhorner alexhorner force-pushed the spi_max7219 branch 4 times, most recently from 2b79ef3 to 462a333 Compare October 4, 2023 19:22
@alexhorner alexhorner marked this pull request as ready for review October 4, 2023 19:45
@cnlohr cnlohr merged commit f1820f2 into cnlohr:master Oct 4, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexhorner @cnlohr