-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyter notebook for heatmap snippet, with three options #6
base: main
Are you sure you want to change the base?
Conversation
I'm not sure how to request to merge this branch into a branch in the CNERG repo that does not yet exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we've finalized the layout of this repo, but instead of PR'ing to another branch, I would recommend PR'ing to master
but with this code in its own directory.
When doing so, also:
- updated the README to describe it better
- the notebook fails when started as-is - I think the data needs the random generation rather than the
arange
Thanks for this addition @opotowsky. I think this approach is particularly useful when your data is on an irregular X/Y grid. There are probably simpler methods for a regular grid. |
Do I need to worry about configuring anything with CircleCI? |
CircleCI is not ready yet. I am not sure if we have a policy on merging before we get that done, or if we want someone to tackle that first??? |
Great, thanks for catching me up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for follow-ups on this topic, @opotowsky !
Took longer than I thought to revisit #3 as it was not my top priority..
Hopefully #3 gets merged successfully soon and then we can think about what to do with CI on this PR.
@opotowsky could you rebase against it should trigger the CI. |
…ADME updated, directory README added
f405fae
to
dd522ea
Compare
Thanks @bam241 ...done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @opotowsky
This snippet is for CNERG folk who want to plot 2D heatmaps given x, y, z experimental data. This uses triangulation to form a triangular grid and then applies matplotlib's tricontourf (or tripcolor) to get the surface plot with a colorbar