Skip to content

Commit

Permalink
Apply suggestions from initial code review by @katyhuff
Browse files Browse the repository at this point in the history
Thanks for this quick review @katyhuff

Co-Authored-By: gonuke <[email protected]>
  • Loading branch information
gonuke authored Feb 15, 2019
1 parent 1d5287c commit 70cf69c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ MESSAGE("-- HDF5 Library directories: ${HDF5_LIBRARY_DIRS}")
MESSAGE("-- HDF5 Libraries: ${HDF5_C_LIBRARIES}")


# Look for MOAB is requested
# Look for MOAB if requested
if(WITH_MOAB)
# user may have set a search path
if(NOT MOAB_ROOT)
Expand Down
9 changes: 4 additions & 5 deletions docker/make_pyne_docker_image.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def build_name(args):
def build_docker(args):
"""Forms the docker command line and executes it. IF the push flag is
provided also pushes it to DockerHub which requires PyNE admin right on
DockerHub(Docker login is assumed(...
DockerHub(Docker login is assumed...)
Parameters
----------
Expand Down Expand Up @@ -90,9 +90,8 @@ def build_docker(args):

def main():
"""Parse the different arguments and call the proper methods.
"""
description = "Build a docker image for PyNE"
description = 'Build a docker image for PyNE'
parser = ap.ArgumentParser(description=description)

py_version = 'Require a specific python version'
Expand All @@ -118,10 +117,10 @@ def main():
parser.add_argument('--deps', help=deps,
action='store_true', default=False)

name = "Set docker imgae name"
name = 'Set docker image name'
parser.add_argument('--name', help=name, default='')

push = 'Push docker imgae on dockerhub'
push = 'Push docker image on dockerhub'
parser.add_argument('--push', '-p', '-push', help=push,
action='store_true', default=False)

Expand Down
1 change: 0 additions & 1 deletion pyne/r2s.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@


def resolve_mesh(mesh_reference, tally_num = None, flux_tag = "n_flux", output_material=False):

"""This function creates a method that will consume many mesh-like objects
(e.g. mesh, an h5m file, a meshtal file, etc) and returns a robust PyNE
mesh object accordingly.
Expand Down

0 comments on commit 70cf69c

Please sign in to comment.