-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSML Models Implementation #38
Conversation
One problem to note: creating tests for neural networks has been tricky. Ideally, these tests should not take several minutes to train and test a method/model. But if we want meaningful test-cases, we will want to test meaningful neural network architectures (which take longer to train). I will be thinking of a compromise... |
The most recent commit changes each |
Split into more PRs? |
"Y", "Z"] | ||
jobs = alph[:n] | ||
|
||
fig, axes = plt.subplots(n, n, figsize=(15, 15)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fig, axes = plt.subplots(n, n, figsize=(15, 15)) | |
fig, axes = plt.subplots(n, n, figsize=(3*n, 3*n)) |
Pull Request Test Coverage Report for Build 3363647923
💛 - Coveralls |
This PR introduces much of the code used for my research comparing several different semi-supervised machine learning models (SSML). I wrote and used these models quite separate from how I have used RadClass in the past (i.e. I ran experimental data through RadClass and H0 to get observations I could use for training and testing ML models separately in a downstream analysis).
This raises a design question regarding how these models and scripts should be integrated into RadClass. Should they be made into a post_analysis object? Should they remain separate, thereby making the user have a script that both runs RadClass for data processing and SSML models for training and testing?
.load
method for each model class? This may remove one manual step a user would have to take to usejoblib
for loading a written model and storing as a model class.