Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volcano Project Security Self-Assessment - Security Pals #1205

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

mayank-nyu
Copy link
Contributor

Created and added reviewed document for the Volcano Project Security Self-Assessment.
Please feel free to share any thoughts on the self-assessment.

@eddie-knight @ragashreeshekar @Rana-KV

Original PR: #1184 (discarded due to Git and DCO issues)

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for tag-security canceled.

Name Link
🔨 Latest commit 7416089
🔍 Latest deploy log https://app.netlify.com/sites/tag-security/deploys/65a96a7e82853700082cdcd7

Co-authored-by: Eddie Knight <[email protected]>
Signed-off-by: Mayank Ramnani <[email protected]>
@mayank-ramnani
Copy link
Contributor

Hi @eddie-knight @ragashreeshekar,
Are there any more changes you'd like us to do before we can merge the PR?


## Self-assessment use

This self-assessment is created by the Volcano team to perform an internal analysis of the project's security. It is not intended to provide a security audit of Volcano, or function as an independent assessment or attestation of Volcano's security health.

This comment was marked as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was initially intended to be a collaboration between the Volcano team and the students, but we were unable to get any feedback from the team.
Fixed it to reflect the independence from the official team.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, that makes more sense

@@ -0,0 +1,59 @@
# Lightweight Threat Modelling
## Threat Modelling Notes
- There are a total of 190 contributors and only 6 maintainers and owners thus there are 184 non-maintainer users who are in the working groups.

This comment was marked as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. If it won't be helpful, it might be best to remove it.
Removed it from the notes and recommendations section.

@@ -0,0 +1,59 @@
# Lightweight Threat Modelling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be careful with the name as these notes are more akin to a lightweight threat analysis/enumeration as opposed to threat modeling which represents a comprehensive exercise (see: OWASP Threat Modeling Process).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, changed it to threat analysis instead.

Copy link
Collaborator

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JustinCappos JustinCappos merged commit fd41be4 into cncf:main Jan 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants