Create Security Self Assessment for Fluentd Project #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tag-security canceled.
|
eddie-knight
reviewed
Dec 8, 2023
eddie-knight
reviewed
Dec 8, 2023
eddie-knight
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Thanks for the PR @Nihal-Rahman and team, appreciate your efforts.
I have completed first pass of review. There are a couple of comments, please review and address them.
Along with addressing the comments, kindly update the PR branch with the latest content in the repo as this branch is out-of-date with the base branch.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
@eddie-knight @ragashreeshekar All the changes requested have been made and all suggestions have been resolved based on their appropriate situations |
Changes requested by CNCF reviewers Fluentd Self Assessment Create Security Self Assessment Signed-off-by: Nihal Rahman <[email protected]> Update self-assessment.md Co-Authored-By: Jeffrey Wong <[email protected]> Co-Authored-By: Garvin Huang <[email protected]> Co-Authored-By: Jin Zhou <[email protected]>
torinvdb
reviewed
Dec 14, 2023
Signed-off-by: Ragashree M C <[email protected]>
ragashreeshekar
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.