Correctly enforce game create rules

cmu-sei · Sep 13, 2024 · eb8466d · eb8466d
1 parent 98f92a1
commit eb8466d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 26 deletions.
diff --git a/src/Gameboard.Api/Features/Game/GameController.cs b/src/Gameboard.Api/Features/Game/GameController.cs
@@ -53,8 +53,11 @@ IUserRolePermissionsService permissionsService
         /// <param name="model"></param>
         /// <returns></returns>
         [HttpPost("api/game")]
-        public Task<Game> Create([FromBody] NewGame model)
-            => GameService.Create(model);
+        public async Task<Game> Create([FromBody] NewGame model)
+        {
+            await Authorize(_permissionsService.Can(PermissionKey.Games_CreateEditDelete));
+            return await GameService.Create(model);
+        }
 
         /// <summary>
         /// Retrieve game

diff --git a/src/Gameboard.Api/Features/Game/GameService.cs b/src/Gameboard.Api/Features/Game/GameService.cs
@@ -38,31 +38,22 @@ public interface IGameService
     Task<bool> UserIsTeamPlayer(string uid, string gid, string tid);
 }
 
-public class GameService : _Service, IGameService
+public class GameService(
+    IGuidService guids,
+    ILogger<GameService> logger,
+    IMapper mapper,
+    CoreOptions options,
+    Defaults defaults,
+    INowService nowService,
+    IUserRolePermissionsService permissionsService,
+    IStore store
+    ) : _Service(logger, mapper, options), IGameService
 {
-    private readonly Defaults _defaults;
-    private readonly IGuidService _guids;
-    private readonly INowService _now;
-    private readonly IUserRolePermissionsService _permissionsService;
-    private readonly IStore _store;
-
-    public GameService(
-        IGuidService guids,
-        ILogger<GameService> logger,
-        IMapper mapper,
-        CoreOptions options,
-        Defaults defaults,
-        INowService nowService,
-        IUserRolePermissionsService permissionsService,
-        IStore store
-    ) : base(logger, mapper, options)
-    {
-        _guids = guids;
-        _defaults = defaults;
-        _now = nowService;
-        _permissionsService = permissionsService;
-        _store = store;
-    }
+    private readonly Defaults _defaults = defaults;
+    private readonly IGuidService _guids = guids;
+    private readonly INowService _now = nowService;
+    private readonly IUserRolePermissionsService _permissionsService = permissionsService;
+    private readonly IStore _store = store;
 
     public async Task<Game> Create(NewGame model)
     {