Merge pull request #86 from cmu-sei/next

3.6.18
cmu-sei · Dec 7, 2022 · 9de599d · 9de599d
2 parents 6ecd3b3 + 807c3b5
commit 9de599d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Gameboard.Api/Features/CubespaceScoreboard/CubespaceScoreboardService.cs b/src/Gameboard.Api/Features/CubespaceScoreboard/CubespaceScoreboardService.cs
@@ -66,7 +66,7 @@ public async Task<CubespaceScoreboardState> GetScoreboard(CubespaceScoreboardReq
             {
                 Id = p.TeamId,
                 // ignore name for now - we'll resolve it later
-                Day1Score = Math.Floor(p.Challenges.Sum(c => c.Score)),
+                Day1Score = p.Score,
                 Day1Playtime = p.Time
             })
                 .DistinctBy(team => team.Id)

diff --git a/src/Gameboard.Api/Features/UnityGames/UnityGameController.cs b/src/Gameboard.Api/Features/UnityGames/UnityGameController.cs
@@ -123,7 +123,7 @@ public async Task<string> UndeployUnitySpace([FromQuery] string gid, [FromRoute]
     /// <returns>ChallengeEvent</returns>
     [Authorize]
     [HttpPost("api/unity/challenge")]
-    public async Task<Data.Challenge> CreateChallenge([FromBody] NewUnityChallenge model)
+    public async Task<IActionResult> CreateChallenge([FromBody] NewUnityChallenge model)
     {
         AuthorizeAny(
             () => _gameService.UserIsTeamPlayer(Actor.Id, model.GameId, model.TeamId).Result
@@ -144,7 +144,7 @@ public async Task<string> UndeployUnitySpace([FromQuery] string gid, [FromRoute]
             challengeData = await _unityGameService.HasChallengeData(model);
             if (challengeData != null)
             {
-                return challengeData;
+                return Accepted();
             }
 
             // otherwise, add new challenge data and send gamebrain the ids of the consoles (which are based on the challenge id)
@@ -190,8 +190,8 @@ public async Task<string> UndeployUnitySpace([FromQuery] string gid, [FromRoute]
         await _hub.Clients
             .Group(model.TeamId)
             .ChallengeEvent(new HubEvent<Challenge>(_mapper.Map<Challenge>(challengeData), EventAction.Updated));
-
-        return challengeData;
+        
+        return Ok();
     }
 
     [HttpPost("api/unity/mission-update")]