Improve clarity of late start error (#364)

cmu-sei · Jan 29, 2024 · 7a4e050 · 7a4e050
1 parent 13e971a
commit 7a4e050
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Gameboard.Api/Features/Player/PlayerExceptions.cs b/src/Gameboard.Api/Features/Player/PlayerExceptions.cs
@@ -8,8 +8,8 @@ namespace Gameboard.Api.Features.Player;
 
 internal class CantLateStart : GameboardValidationException
 {
-    internal CantLateStart(string captainPlayerId, string gameId, DateTimeOffset gameEnd, int sessionLength)
-        : base($"Can't start team {captainPlayerId} in game {gameId}. The game ends at {gameEnd}, which is within a session length of {sessionLength} minutes from now.") { }
+    internal CantLateStart(string teamName, string gameName, DateTimeOffset gameEnd, int sessionLength)
+        : base($"Can't start team {teamName} in game {gameName}. The game ends at {gameEnd}, which is within a session length of {sessionLength} minutes from now.") { }
 }
 
 internal class CantResolveTeamFromCode : GameboardException

diff --git a/src/Gameboard.Api/Features/Player/PlayerService.cs b/src/Gameboard.Api/Features/Player/PlayerService.cs
@@ -246,7 +246,7 @@ public async Task<Player> StartSession(SessionStartRequest model, User actor, bo
 
         // rule: if the player/team is starting late, this must be allowed on the game level
         if (sessionWindow.IsLateStart && !game.AllowLateStart)
-            throw new CantLateStart(player.Id, game.Id, game.GameEnd, game.SessionMinutes);
+            throw new CantLateStart(player.Name, game.Name, game.GameEnd, game.SessionMinutes);
 
         foreach (var p in team)
         {