Fix autotags bug

cmu-sei · Sep 20, 2024 · 17225e9 · 17225e9
1 parent d11246e
commit 17225e9
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/src/Gameboard.Api/Features/Ticket/TicketService.cs b/src/Gameboard.Api/Features/Ticket/TicketService.cs
@@ -474,6 +474,17 @@ internal IEnumerable<string> TransformTicketLabels(string labels)
 
     private async Task UpdatedSessionContext(Data.Ticket entity)
     {
+        var autoTags = await _autoTagService.GetAutoTags(entity, CancellationToken.None);
+        var finalTags = new List<string>(entity.Label.Split(LABELS_DELIMITER, StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries));
+
+        foreach (var autoTag in autoTags)
+        {
+            if (!finalTags.Contains(autoTag))
+            {
+                finalTags.Add(autoTag.Trim());
+            }
+        }
+
         if (!entity.ChallengeId.IsEmpty())
         {
             var challenge = await _store
@@ -485,7 +496,6 @@ private async Task UpdatedSessionContext(Data.Ticket entity)
             {
                 entity.TeamId = challenge.TeamId;
                 entity.PlayerId = challenge.PlayerId;
-                entity.Label = string.Empty;
                 return;
             }
         }
@@ -504,17 +514,6 @@ private async Task UpdatedSessionContext(Data.Ticket entity)
             }
         }
 
-        var autoTags = await _autoTagService.GetAutoTags(entity, CancellationToken.None);
-        var finalTags = new List<string>(entity.Label.Split(LABELS_DELIMITER, StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries));
-
-        foreach (var autoTag in autoTags)
-        {
-            if (!finalTags.Contains(autoTag))
-            {
-                finalTags.Add(autoTag);
-            }
-        }
-
         entity.Label = string.Join(LABELS_DELIMITER, finalTags);
         entity.TeamId = null;
         entity.ChallengeId = null;