Cmu image improvements #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @austin-schick and I were just talking yesterday about some image performance optimizations. Does this look helpful to you, Austin? |
|
Hi, just following up on this PR. Are there any updates or additional changes needed? It would be great to have these improvements available for students soon. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes have been made:
Image()ordrawImage()functions now gives an appropriate error with a suggestion on the potential source of the error (addresess Passing a PIL image to drawImage in Desktop CMU Graphics causes a confusing error #67)This PR introduces useful changes without much modification, so hopefully it can be merged quickly for the student to use.