Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POWHEG-RES Change #3716

Merged
merged 2 commits into from
Nov 4, 2024
Merged

POWHEG-RES Change #3716

merged 2 commits into from
Nov 4, 2024

Conversation

jshin96
Copy link
Contributor

@jshin96 jshin96 commented May 28, 2024

Modified the patches such that it includes updated loop calculation codes and compile those codes that need separate compilation.

@agrohsje
Copy link
Collaborator

We heavily rely on pulling code from external sites. Shouldn't we copy to our gen space and pull from there. @menglu21 @bbilin @DickyChant @sihyunjeon @covarell ?

@covarell
Copy link
Contributor

Hi @agrohsje , for the moment only local gridpack making is supported (on lxplus8 or equivalent) so I don't think pulling code from external sites should be a problem. On the other side, we automatically get updates.

@menglu21
Copy link
Collaborator

menglu21 commented Jun 4, 2024

@jshin96 all these updates are validated, right. As for using GEN website, maybe we can add another try between the first "wget" and "fail_exit",
wget --user NLOX --password LoopsAreCool http://www.hep.fsu.edu/~nlox/downloads/v1.2.1/NLOX_1.2.1.tar.gz || fail_exit \"Failed to get NLOX_1.2.1 tar ball\"\n \
to
{wget --user NLOX --password LoopsAreCool http://www.hep.fsu.edu/~nlox/downloads/v1.2.1/NLOX_1.2.1.tar.gz || wget XXXX GENWEBPLACE} || fail_exit \"Failed to get NLOX_1.2.1 tar ball\"\n \ to enable the wget can always succeed and get the package from official place as much as possible

@covarell
Copy link
Contributor

@jshin96 , can you please fix this suggestion from @menglu21 , so we can proceed with this PR?

@jshin96
Copy link
Contributor Author

jshin96 commented Jun 27, 2024

@menglu21 Sorry for late response, I was bit caught up with attending AEPSHEP. By "XXXX GENWEBPLACE", could you give me an example of where these webplace is?

@menglu21
Copy link
Collaborator

menglu21 commented Jul 9, 2024

Hi @jshin96 actually my comment is based on Alex's comment, copy them to /eos/project/c/cmsweb/www/generators/directories/cms-project-generators, and try to download from this path if downloading from their official site is failing

@covarell
Copy link
Contributor

Hi again, can we merge this now (I am not sure if the above unsuccessful checks are meaningful or just depend on strange Linux version conflicts)?

@agrohsje
Copy link
Collaborator

agrohsje commented Nov 2, 2024

Dear @bbilin @lviliani @covarell @DickyChant @sihyunjeon @jshin96 : What is the status with this PR? Who is supposed to work on it? We urgently need to split code and cards. We really put our MC production at risk if we don't follow up on such essential requests.

@bbilin
Copy link
Collaborator

bbilin commented Nov 4, 2024

The last question was asked by Meng, who was reviewing the pr. Then, we simply missed the last update, as there was no message but just another commit. To me this looks fine and we can merge it.

@bbilin bbilin merged commit 42c37d1 into cms-sw:master Nov 4, 2024
3 of 6 checks passed
@jshin96
Copy link
Contributor Author

jshin96 commented Nov 5, 2024 via email

@covarell
Copy link
Contributor

covarell commented Nov 5, 2024

Hi, I am testing this now generally on POWHEG-RES (see also #3795).

As @Cvico noticed, it is particularly important to have back processes including OpenLoops. Unfortunately for those with GoSam, there is no other way than having authors fix the fortran code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants