Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTD Validation]: update to MtdTracksValidation #46931

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martinamalberti
Copy link
Contributor

PR description:

This PR provides an update of the MtdTracksValidation class:

  • add requirement that the sim direct hit is in BTL for tracks within trackMaxBtlEta_

  • update Configuration.Geometry cff in the config files mtdTracksValidation_cfg.py and mtdHarvesting_cfg.py

PR validation:

Code compiles, runs and produces the desired plots. It was tested on:
/RelValSingleMuPt10/CMSSW_14_2_0_pre4-141X_mcRun4_realistic_v3_STD_RegeneratedGS_2026D110_noPU-v1/GEN-SIM-RECO

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @martinamalberti for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@fabiocos, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2625ec/43433/summary.html
COMMIT: 9680a46
CMSSW: CMSSW_15_0_X_2024-12-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46931/43433/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants