New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Etau trigger pr branch #46924

Open

rdewanje wants to merge 2 commits into cms-sw:master from rdewanje:etau_trigger_PR_branch

+631 −1

Contributor

rdewanje commented Dec 12, 2024

PR description:

Added the Electron+Tau cross trigger path to the existing Phase-2 HLT Menu after following the recipe given here:
https://cmshltupgrade.docs.cern.ch/RunningInstructions/

PR validation:

PR passed all test mentioned here:
https://cms-sw.github.io/PRWorkflow.html

rdewanje added 2 commits

December 11, 2024 12:32


          Added E-Tau Trigger path files

d881ffc


          Added the E-Tau trigger in the HLT_75e33_cff.py file

ba6317d

cmsbuild added this to the CMSSW_15_0_X milestone

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels

Contributor

cmsbuild commented Dec 12, 2024 •

edited

Loading

cms-bot internal usage

Contributor

cmsbuild commented Dec 12, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46924/42986

cmsbuild added code-checks-approved and removed code-checks-pending labels

Contributor

cmsbuild commented Dec 12, 2024

A new Pull Request was created by @rdewanje for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich reviewed

View reviewed changes

Contributor

mmusich left a comment •

edited

Loading

Please update the PR title to be meaningful (as in "Add Electron Tau cross-trigger to the HLT Phase-2 menu")

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+              from ..sequences.HLTPFTauHPS_cfi import *
+              from ..sequences.HLTHPSDeepTauPFTauSequence_cfi import *
+              #from ..sequences.RawToDigiSequence_cfi import *  ## CHANGED TO FILE BELOW

Contributor

mmusich Dec 12, 2024

Suggested change

#from ..sequences.RawToDigiSequence_cfi import * ## CHANGED TO FILE BELOW

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+              #from ..sequences.RawToDigiSequence_cfi import *  ## CHANGED TO FILE BELOW
+              from ..sequences.HLTRawToDigiSequence_cfi import *
+              #from ..sequences.hgcalLocalRecoSequence_cfi import * ## CHANGED TO FILE BELOW

Contributor

mmusich Dec 12, 2024

Suggested change

#from ..sequences.hgcalLocalRecoSequence_cfi import * ## CHANGED TO FILE BELOW

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+              #from ..sequences.hgcalLocalRecoSequence_cfi import * ## CHANGED TO FILE BELOW
+              from ..sequences.HLTHgcalLocalRecoSequence_cfi import *
+              #from ..sequences.localrecoSequence_cfi import * ## CHANGED TO FILE BELOW

Contributor

mmusich Dec 12, 2024

Suggested change

#from ..sequences.localrecoSequence_cfi import * ## CHANGED TO FILE BELOW

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

Comment on lines +63 to +73

+              #hltEG30EtL1SeededFilter = _hltEG32EtL1SeededFilter.clone(
+              #    etcutEB = cms.double(30.0),
+              #    etcutEE = cms.double(30.0),
+              #    inputTag = cms.InputTag("hltEgammaCandidatesWrapperL1Seeded"),
+              #    l1EGCand = cms.InputTag("hltEgammaCandidatesL1Seeded"),
+              #    ncandcut = cms.int32(1),
+              #    saveTags = cms.bool(True)
+              #)

Contributor

mmusich Dec 12, 2024

Suggested change

      
            #hltEG30EtL1SeededFilter = _hltEG32EtL1SeededFilter.clone(
          
            #    etcutEB = cms.double(30.0), 
          
            #    etcutEE = cms.double(30.0), 
          
            #    inputTag = cms.InputTag("hltEgammaCandidatesWrapperL1Seeded"),
          
            #    l1EGCand = cms.InputTag("hltEgammaCandidatesL1Seeded"),
          
            #    ncandcut = cms.int32(1),
          
            #    saveTags = cms.bool(True)
          
            #)

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+                  HLTBeginSequence +
+                  hltPuppiTauTkIsoEle4522L1TkFilter +
+                  #RawToDigiSequence +

Contributor

mmusich Dec 12, 2024

Suggested change

#RawToDigiSequence +

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+                  #RawToDigiSequence +
+                  HLTRawToDigiSequence +
+                  #hgcalLocalRecoSequence +

Contributor

mmusich Dec 12, 2024

Suggested change

#hgcalLocalRecoSequence +

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+                  #hgcalLocalRecoSequence +
+                  HLTHgcalLocalRecoSequence +
+                  #localrecoSequence +

Contributor

mmusich Dec 12, 2024

Suggested change

#localrecoSequence +

HLTrigger/Configuration/python/HLT_75e33_cff.py

@@ @@ -404,7 +405,7 @@ @@
                   fragment.HLT_DoubleMediumChargedIsoPFTauHPS40_eta2p1,
                   fragment.HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1,
                   fragment.HLT_IsoMu20_eta2p1_LooseDeepTauPFTauHPS27_eta2p1_CrossL1,
+                  fragment.HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1,

Contributor

mmusich Dec 12, 2024

please add this trigger also in the timing variant of the menu at HLTrigger/Configuration/python/HLT_75e33_timing_cff.py

Contributor

mmusich commented Dec 12, 2024

test parameters:

enable = hlt_p2_integration

Contributor

mmusich commented Dec 13, 2024

@rdewanje please clarify if there will be follow-ups to the review. In particular addressing #46924 (comment) is necessary before starting tests.

Contributor

rovere commented Dec 13, 2024 •

edited

Loading

Dear all, unless this new cross trigger path is added also to the timing flavour of the Phase-2 HLT menu, the timing measurements will be irrelevant/useless.

Contributor

mmusich commented Dec 13, 2024

Dear all, unless this new cross trigger path is added also to the trigger flavour of the Phase-2 HLT menu, the timing measurements will be irrelevant/useless.

that's precisely my comment at #46924 (comment) and #46924 (comment) @rdewanje

Contributor

rovere commented Dec 13, 2024

Dear all, unless this new cross trigger path is added also to the trigger flavour of the Phase-2 HLT menu, the timing measurements will be irrelevant/useless.

that's precisely my comment at #46924 (comment) and #46924 (comment) @rdewanje

thanks Marco! Repetita iuvant. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-checks-approved hlt-pending orp-pending pending-signatures tests-pending