Removing CUDA/`gpu` from Pixel code configs and dropping all CUDA wfs #46853

AdrianoDee · 2024-12-03T14:08:55Z

PR description:

This PR proposes:

the removal of all the CUDA modules from pixel-related configs and of all the CUDA Patatrack wfs;
the removal of pixelNtupletFit_cff modifier.

A subsequent step would be to remove the gpu modifier, but since this involves code from many parties, I prefer to have it separated.

cmsbuild · 2024-12-03T14:09:22Z

cms-bot internal usage

AdrianoDee · 2024-12-03T14:10:02Z

Well, apparently already these changes involve many parties. So maybe I'll push the drop of the gpu modifier already here.

AdrianoDee · 2024-12-03T14:10:25Z

enable gpu

AdrianoDee · 2024-12-03T14:10:28Z

please test

cmsbuild · 2024-12-03T14:10:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46853/42877

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): Add run3 tracking low pu era #33532, ECAL RecHit producer Alpaka migration #46453, Addition of single iteration Patatrack and LST HLT configurations and workflows #46828
- File Configuration/PyReleaseValidation/python/relval_gpu.py modified in PR(s): ECAL RecHit producer Alpaka migration #46453
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, ECAL RecHit producer Alpaka migration #46453, Allowing Cluster Splitting with HLT Vertices #46694, Addition of single iteration Patatrack and LST HLT configurations and workflows #46828
- File EventFilter/SiPixelRawToDigi/python/SiPixelRawToDigi_cfi.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File EventFilter/SiPixelRawToDigi/python/siPixelDigis_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File RecoHI/HiTracking/python/HILowPtConformalPixelTracks_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelClusterizer/python/SiPixelClusterizerPreSplitting_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelClusterizer/python/siPixelClustersPreSplitting_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelRecHits/python/PixelCPEESProducers_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952, Remove the configuration of the legacy CUDA workflows #46076
- File RecoTracker/PixelTrackFitting/python/PixelTracks_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoVertex/BeamSpotProducer/python/BeamSpot_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File RecoVertex/Configuration/python/RecoPixelVertexing_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2024-12-03T14:10:58Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Configuration/ProcessModifiers (operations)
Configuration/PyReleaseValidation (pdmv, upgrade)
EventFilter/SiPixelRawToDigi (reconstruction)
RecoHI/HiTracking (reconstruction)
RecoLocalTracker/SiPixelClusterizer (reconstruction)
RecoLocalTracker/SiPixelRecHits (reconstruction)
RecoTracker/PixelTrackFitting (reconstruction)
RecoVertex/BeamSpotProducer (reconstruction, alca)
RecoVertex/Configuration (reconstruction)

@AdrianoDee, @Moanwar, @antoniovilela, @atpathak, @consuegs, @davidlange6, @DickyChant, @fabiocos, @jfernan2, @mandrenguyen, @miquork, @perrotta, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @dkotlins, @fabiocos, @felicepantaleo, @ferencek, @francescobrivio, @gpetruc, @jazzitup, @kurtejung, @makortel, @mandrenguyen, @martinamalberti, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @rsreds, @slomeo, @threus, @tocheng, @tsusa, @tvami, @yenjie, @yetkinyilmaz, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2024-12-03T14:40:19Z

assign heterogeneous

cmsbuild · 2024-12-03T14:40:42Z

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2024-12-03T15:08:09Z

-1

Failed Tests: UnitTests RelVals RelVals-GPU RelVals-INPUT AddOn
Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-693680/43213/summary.html
COMMIT: 5d626de
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46853/43213/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 34 errors in the following unit tests:

---> test TestDQMOnlineClient-es_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-beamhlt_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-csc_dqm_sourceclient had ERRORS
and more ...

RelVals

135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
1306.01306.0_SingleMuPt1_UP15/step1_SingleMuPt1_UP15.log
7.37.3_CosmicsSPLoose2018/step1_CosmicsSPLoose2018.log

Expand to see more relval errors ...

RelVals-GPU

12834.42312834.423_TTbar_14TeV+2024_Patatrack_HCALOnlyGPUandAlpaka_Validation/step1_TTbar_14TeV+2024_Patatrack_HCALOnlyGPUandAlpaka_Validation.log
12834.42212834.422_TTbar_14TeV+2024_Patatrack_HCALOnlyAlpaka_Validation/step1_TTbar_14TeV+2024_Patatrack_HCALOnlyAlpaka_Validation.log
12834.40612834.406_TTbar_14TeV+2024_Patatrack_PixelOnlyTripletsAlpaka/step1_TTbar_14TeV+2024_Patatrack_PixelOnlyTripletsAlpaka.log

Expand to see more relval errors ...

RelVals-INPUT

159.01159.01_HydjetQ_reminiaodPbPb2022_INPUT/step2_HydjetQ_reminiaodPbPb2022_INPUT.log
136.875136.875_RunDoubleMuon2018C/step2_RunDoubleMuon2018C.log
2500.2252500.225_jmeNANOrePuppimc140X/step2_jmeNANOrePuppimc140X.log

Expand to see more relval errors ...

AddOn Tests

fastsim

UNKNOWN

fastsim1

UNKNOWN

fastsim2

UNKNOWN

Expand to see more addon errors ...

cmsbuild · 2024-12-10T12:51:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46853/42956

There are other open Pull requests which might conflict with changes you have proposed:
- File Calibration/LumiAlCaRecoProducers/python/ALCARECOLumiPixels_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File Configuration/PyReleaseValidation/README.md modified in PR(s): Add run3 tracking low pu era #33532, ECAL RecHit producer Alpaka migration #46453
- File Configuration/PyReleaseValidation/python/relval_gpu.py modified in PR(s): ECAL RecHit producer Alpaka migration #46453
- File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): Implement eras for Run3 2025 PbPb UPC and oxygen runs #46878, Standard 2024(2022,2023) Wfs For PR Testing #46880
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Implement eras for Run3 2025 PbPb UPC and oxygen runs #46878, Standard 2024(2022,2023) Wfs For PR Testing #46880, Run-dependent pixel simulation using additionally compressed SimHit info #46884
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, ECAL RecHit producer Alpaka migration #46453, [NGT] Implement new seeding module for HLT Standalone Muon seeding and streamline HLT L3 Tracker Muon reconstruction #46897
- File Configuration/PyReleaseValidation/scripts/README.md modified in PR(s): Standard 2024(2022,2023) Wfs For PR Testing #46880
- File Configuration/StandardSequences/python/RawToDigi_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File Configuration/StandardSequences/python/Services_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/beampixel_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/csc_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/fed_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1t_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1temulator_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage1_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage1emulator_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage2emulator_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/lumi_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/physics_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/scal_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/sistrip_approx_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Physics/python/qcdLowPtDQM_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File EventFilter/SiPixelRawToDigi/python/SiPixelRawToDigi_cfi.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File EventFilter/SiPixelRawToDigi/python/siPixelDigis_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File RecoHI/HiTracking/python/HILowPtConformalPixelTracks_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelClusterizer/python/SiPixelClusterizerPreSplitting_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelClusterizer/python/siPixelClustersPreSplitting_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelRecHits/python/PixelCPEESProducers_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952, Remove the configuration of the legacy CUDA workflows #46076
- File RecoTracker/PixelTrackFitting/python/PixelTracks_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoVertex/BeamSpotProducer/python/BeamSpot_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File RecoVertex/Configuration/python/RecoPixelVertexing_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2024-12-10T12:51:24Z

Pull request #46853 was updated. @AdrianoDee, @Moanwar, @antoniovagnerini, @antoniovilela, @atpathak, @consuegs, @davidlange6, @DickyChant, @fabiocos, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @miquork, @perrotta, @rappoccio, @rseidita, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild · 2024-12-10T14:45:09Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-693680/43349/summary.html
COMMIT: 72e2818
CMSSW: CMSSW_15_0_X_2024-12-09-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46853/43349/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOnlineClients-compilation_hi_run had ERRORS

Comparison Summary

Summary:

You potentially removed 108 lines from the logs
Reco comparison results: 26 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3623082
DQMHistoTests: Total failures: 1869
DQMHistoTests: Total nulls: 12
DQMHistoTests: Total successes: 3621181
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.8100000000000004 KiB( 46 files compared)
DQMHistoSizes: changed ( 12434.7,... ): -0.012 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 12434.7,... ): -0.012 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 24834.911,... ): -0.008 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 24834.911,... ): -0.008 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 4.22,... ): -0.004 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 4.22,... ): -0.004 KiB MessageLogger/Warnings
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

You potentially removed 42 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53058
DQMHistoTests: Total failures: 52
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 53006
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

AdrianoDee · 2024-12-10T14:50:01Z

please test

cmsbuild · 2024-12-10T14:52:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46853/42959

There are other open Pull requests which might conflict with changes you have proposed:
- File Calibration/LumiAlCaRecoProducers/python/ALCARECOLumiPixels_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File Configuration/PyReleaseValidation/README.md modified in PR(s): Add run3 tracking low pu era #33532, ECAL RecHit producer Alpaka migration #46453
- File Configuration/PyReleaseValidation/python/relval_gpu.py modified in PR(s): ECAL RecHit producer Alpaka migration #46453
- File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): Implement eras for Run3 2025 PbPb UPC and oxygen runs #46878, Standard 2024(2022,2023) Wfs For PR Testing #46880
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Implement eras for Run3 2025 PbPb UPC and oxygen runs #46878, Standard 2024(2022,2023) Wfs For PR Testing #46880, Run-dependent pixel simulation using additionally compressed SimHit info #46884
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, ECAL RecHit producer Alpaka migration #46453, [NGT] Implement new seeding module for HLT Standalone Muon seeding and streamline HLT L3 Tracker Muon reconstruction #46897
- File Configuration/PyReleaseValidation/scripts/README.md modified in PR(s): Standard 2024(2022,2023) Wfs For PR Testing #46880
- File Configuration/StandardSequences/python/RawToDigi_Repacked_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File Configuration/StandardSequences/python/RawToDigi_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File Configuration/StandardSequences/python/Services_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/beampixel_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/csc_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/fed_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1t_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1temulator_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage1_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage1emulator_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage2emulator_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/lumi_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/physics_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/scal_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/sistrip_approx_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Physics/python/qcdLowPtDQM_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File EventFilter/SiPixelRawToDigi/python/SiPixelRawToDigi_cfi.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File EventFilter/SiPixelRawToDigi/python/siPixelDigis_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File RecoHI/HiTracking/python/HILowPtConformalPixelTracks_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelClusterizer/python/SiPixelClusterizerPreSplitting_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelClusterizer/python/siPixelClustersPreSplitting_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoLocalTracker/SiPixelRecHits/python/PixelCPEESProducers_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952, Remove the configuration of the legacy CUDA workflows #46076
- File RecoTracker/PixelTrackFitting/python/PixelTracks_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File RecoVertex/BeamSpotProducer/python/BeamSpot_cff.py modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853, Remove the configuration of the legacy CUDA workflows #46076
- File RecoVertex/Configuration/python/RecoPixelVertexing_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2024-12-10T14:52:37Z

Pull request #46853 was updated. @AdrianoDee, @Moanwar, @antoniovagnerini, @antoniovilela, @atpathak, @consuegs, @davidlange6, @DickyChant, @fabiocos, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @miquork, @perrotta, @rappoccio, @rseidita, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild · 2024-12-10T16:58:52Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-693680/43355/summary.html
COMMIT: 8cf7a09
CMSSW: CMSSW_15_0_X_2024-12-09-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46853/43355/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 106 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3623082
DQMHistoTests: Total failures: 445
DQMHistoTests: Total nulls: 11
DQMHistoTests: Total successes: 3622606
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.8100000000000004 KiB( 46 files compared)
DQMHistoSizes: changed ( 12434.7,... ): -0.012 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 12434.7,... ): -0.012 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 24834.911,... ): -0.008 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 24834.911,... ): -0.008 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 4.22,... ): -0.004 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 4.22,... ): -0.004 KiB MessageLogger/Warnings
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

You potentially removed 42 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53058
DQMHistoTests: Total failures: 29
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 53029
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

cmsbuild added this to the CMSSW_15_0_X milestone Dec 3, 2024

cmsbuild added reconstruction-pending alca-pending operations-pending pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending tracking trk labels Dec 3, 2024

cmsbuild added tests-started and removed tests-pending labels Dec 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 3, 2024

cmsbuild added the heterogeneous-pending label Dec 3, 2024

cmsbuild added tests-rejected and removed tests-started labels Dec 3, 2024

AdrianoDee force-pushed the remove_cuda_wfs_and_pixel_cfgs branch from 5d626de to 77de940 Compare December 3, 2024 15:12

cmsbuild removed the tests-rejected label Dec 3, 2024

cmsbuild added tests-started code-checks-pending and removed code-checks-approved labels Dec 10, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 10, 2024

cmsbuild added tests-rejected and removed tests-started labels Dec 10, 2024

Small fixes

8cf7a09

AdrianoDee force-pushed the remove_cuda_wfs_and_pixel_cfgs branch from 72e2818 to 8cf7a09 Compare December 10, 2024 14:49

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Dec 10, 2024

cmsbuild added tests-started and removed tests-pending labels Dec 10, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 10, 2024

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Dec 10, 2024

This was referenced Dec 11, 2024

Restoring 2023 RelVal Inputs #46909

Merged

quarter core processor for HL-LHC inner tracker developments #45759

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing CUDA/`gpu` from Pixel code configs and dropping all CUDA wfs #46853

Removing CUDA/`gpu` from Pixel code configs and dropping all CUDA wfs #46853

AdrianoDee commented Dec 3, 2024 •

edited

Loading

cmsbuild commented Dec 3, 2024 •

edited

Loading

AdrianoDee commented Dec 3, 2024 •

edited

Loading

AdrianoDee commented Dec 3, 2024

AdrianoDee commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

jfernan2 commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

cmsbuild commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

AdrianoDee commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

Removing CUDA/gpu from Pixel code configs and dropping all CUDA wfs #46853

Are you sure you want to change the base?

Removing CUDA/gpu from Pixel code configs and dropping all CUDA wfs #46853

Conversation

AdrianoDee commented Dec 3, 2024 • edited Loading

PR description:

cmsbuild commented Dec 3, 2024 • edited Loading

AdrianoDee commented Dec 3, 2024 • edited Loading

AdrianoDee commented Dec 3, 2024

AdrianoDee commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

jfernan2 commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

cmsbuild commented Dec 3, 2024

Unit Tests

RelVals

RelVals-GPU

RelVals-INPUT

AddOn Tests

cmsbuild commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

Unit Tests

Comparison Summary

GPU Comparison Summary

AdrianoDee commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

cmsbuild commented Dec 10, 2024

Comparison Summary

GPU Comparison Summary

Removing CUDA/`gpu` from Pixel code configs and dropping all CUDA wfs #46853

Removing CUDA/`gpu` from Pixel code configs and dropping all CUDA wfs #46853

AdrianoDee commented Dec 3, 2024 •

edited

Loading

cmsbuild commented Dec 3, 2024 •

edited

Loading

AdrianoDee commented Dec 3, 2024 •

edited

Loading