Mark all Fireworks dictionaries as transient

[makortel]

PR description:

The Fireworks/* packages are not a data format packages, and I strongly suspect these dictionaries are defined for other reasons than to be stored by the framework. Found in #45423 (comment)

Resolves cms-sw/framework-team#961

PR validation:

Code compiles, and the to-be-added edmDumpClassVersion succeeds to process the classes_def.xml files.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45546/41023

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• Fireworks/Core (visualization)
• Fireworks/Eve (visualization)
• Fireworks/FWInterface (visualization)
• Fireworks/TableWidget (visualization)
• Fireworks/Vertices (visualization)

@Dr15Jones, @alja, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

type -changes-dataformats

[makortel]

@cmsbuild, please test

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[alja]

@makortel I'm just checking if versioning/changes in Fireworks dictionaries will be supported. I see 'persistent' flag set to false, but I don't exactly know what that means.

[makortel]

@alja In short, persistent="false" means that the object may not be stored in a ROOT file via framework's OutputModules.

IFAIK the attribute is custom to CMS, i.e. ROOT itself doesn't act on it. By policy dictionaries without persistent="false" (i.e. data types that are allowed to be persisted) are allowed to be defined in DataFormat packages. We are working towards enforcing these policies as part of PR/IB tests.

I'd expect changing (or adding/removing) Fireworks classes to be fine as long as the persistent="false" attribute is kept on the classes_def.xml. You mentioned "versioning", could you elaborate on that? I mean, what kind of versioning (and for what use case) are you thinking about?

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74b19f/40576/summary.html
COMMIT: 379f096
CMSSW: CMSSW_14_1_X_2024-07-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45546/40576/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 2500.2452500.245_hcalDPGCalibNANO140Xrun3/step2_hcalDPGCalibNANO140Xrun3.log

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 99 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3325254
• DQMHistoTests: Total failures: 2470
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3322764
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[makortel]

Failure in 2500.245 is a file open error, comparison differences are related to #39803

[alja]

@makortel Thank you for the info. About the class changes I had in mind changes in members or functions. Thinking about Fireworks use case, I don't think we will ever need to access an older version of Firework's class dictionaries. I'm sorry for the confusion.

[makortel]

@alja Thanks for the clarification. I'd expect all that kind of modifications to work just fine.

[makortel]

ignore tests-rejected with ib-failure

[mandrenguyen]

+1