Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRule]Fix for code checks #9575

Open
wants to merge 3 commits into
base: IB/CMSSW_15_0_X/master
Choose a base branch
from

Conversation

smuzaffar
Copy link
Contributor

New cmssw-config tag which fixes code-checks. Once this is merged and available in the IBs then

  • we will open cmssw PR to apply to code-checks ( clang-tidy) on the files which were merged without clang-tidy fixes.
  • Already open PRs (when updated) might fail code checks

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#46930

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_0_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43427/summary.html
COMMIT: 0ab7188
CMSSW: CMSSW_15_0_X_2024-12-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9575/43427/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e
+ echo V09-06-09
+ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e/config/updateConfig.py -p CORAL -v CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e -s V3_00_80 -t /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/cms/coral-tool-conf/100.0-979c92bc71965f26443fe2cc86e2a196 --keys SCRAM_COMPILER=gcc --keys ENABLE_LTO=1 --keys PROJECT_GIT_HASH=CORAL_2_3_21 --keys ENABLE_PGO=0
+ echo -e ''
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.kVKtzD: line 64: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/a06072cdf4d39d36e7acac67ae8cef1e/opt/cmssw/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e/config/toolbox/el8_amd64_gcc12/tools/selected/cmssw-config.xml: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.kVKtzD (%prep)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+coral+CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.kVKtzD (%prep)


@cmsbuild
Copy link
Contributor

Pull request #9575 was updated.

@cmsbuild
Copy link
Contributor

Pull request #9575 was updated.

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#46930

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#46930

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43432/summary.html
COMMIT: 9c15534
CMSSW: CMSSW_15_0_X_2024-12-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9575/43432/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-scram-code-checks had ERRORS

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants