alexis tidying up notes #880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etelan
commented
May 26, 2023
|
|
||
| **A:** There isn't a system in place for this but there doesn't need to be since you can just type `ACCOUNTNAME PASSWORD` in the password field to get the password for that account. | ||
|
|
||
| <br/> | ||
|
|
||
| <a name="cookies">**Q:** What are cookies and why do you use them?:</a> | ||
| <a name="cookies">**Q:** What are cookies and why do you use them?</a> | ||
|
|
||
| **A:** A cookie is a small bit of information that a website stores on your computer so that when you come back to the site later, it can remember things from your previous visit. Cloverleaf uses these for remembering what theme you like and a few other things like that. |
There was a problem hiding this comment.
Would be good to show what exactly the cookies are used for, with links to where they are defined in the codebase.
etelan
commented
May 26, 2023
src/style.scss
Outdated
There was a problem hiding this comment.
LN 10-41, there are a bunch of variables defined. Would it be possible to move these to a seperate file, or add comments to explain?
etelan
commented
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.