Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement tunnel-based APIs (Exec, Attach, Portforward) #6

Merged
merged 17 commits into from
Aug 19, 2023
Merged

feat: Implement tunnel-based APIs (Exec, Attach, Portforward) #6

merged 17 commits into from
Aug 19, 2023

Conversation

danopia
Copy link
Member

@danopia danopia commented Aug 12, 2023 •
edited
Loading

Steps

  • Fix typing of command parameter used for argv. (workaround Kubernetes OpenAPI inaccuracy)
  • Catch tunnel-based APIs in codegen and treat them specially
  • Implement user-friendly classes for specific protocols:
    • For stdio tunnels (PodExec, PodAttach)
    • For TCP tunnels (PodPortforward)
  • Create and return the new user-friendly classes for recognized APIs
  • Add minimal test

Context

@danopia danopia mentioned this pull request Aug 13, 2023
Closed
@danopia danopia marked this pull request as ready for review August 14, 2023 17:01
@danopia danopia merged commit ab32ebf into main Aug 19, 2023
4 checks passed
@danopia danopia deleted the impl-tunnel-apis branch August 19, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connectPostPodExec is not implemented
1 participant
@danopia