Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pilota-thrift-parser): trim extra whitespace characters at the end of annotation list item #281

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

Ggiggle
Copy link
Contributor

@Ggiggle Ggiggle commented Nov 4, 2024

Motivation

The previous annotations‘ parser was not compatible with extra null characters at the end of the list. Thus, the apache thrift test data would encounter error for its blank after the last list item.

Solution

We will identify and remove whitespace characters at the end of the list item. Considering multiple list parsing scenarios, we choose to remove whitespace characters in the extraction of each list item separator, although these characters may have been extracted in the outer layer.

@Ggiggle Ggiggle requested review from a team as code owners November 4, 2024 02:30
@Ggiggle Ggiggle changed the title fix(pilota-thrift-parser): trim extra whitespace characters at the end of annotation list fix(pilota-thrift-parser): trim extra whitespace characters at the end of annotation list item Nov 4, 2024
PureWhiteWu
PureWhiteWu previously approved these changes Nov 4, 2024
@Ggiggle Ggiggle merged commit 34d6fd4 into main Nov 4, 2024
10 checks passed
@Ggiggle Ggiggle deleted the fix/trim_blank branch November 4, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants