Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sonic to support Go1.21 #914

Closed
wants to merge 3 commits into from
Closed

Conversation

GuangmingLuo
Copy link
Member

@GuangmingLuo GuangmingLuo commented Aug 17, 2023

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: update sonic to support Go1.21 & remove unused images.
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@GuangmingLuo GuangmingLuo requested review from a team as code owners August 17, 2023 08:51
@GuangmingLuo GuangmingLuo changed the title chore: update sonic to support Go1.20 chore: update sonic to support Go1.21 Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.02% ⚠️

Comparison is base (a3770c3) 80.30% compared to head (7b036b6) 80.28%.
Report is 2 commits behind head on develop.

❗ Current head 7b036b6 differs from pull request most recent head c0955a3. Consider uploading reports for the commit c0955a3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #914      +/-   ##
===========================================
- Coverage    80.30%   80.28%   -0.02%     
===========================================
  Files           97       97              
  Lines         9602     9604       +2     
===========================================
  Hits          7711     7711              
- Misses        1408     1409       +1     
- Partials       483      484       +1     
Files Changed Coverage Δ
pkg/protocol/http1/ext/common.go 70.32% <66.66%> (+0.19%) ⬆️
pkg/common/utils/chunk.go 93.93% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@welkeyever
Copy link
Member

This update is not necessary triggered at the hertz side - users can update directly in their own projects.

Please let me know if there is anything I'm missing.

@welkeyever welkeyever added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Development

Successfully merging this pull request may close these issues.

2 participants