Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add comment for method Redirect and Header #868

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

Tom-debug110
Copy link
Contributor

What type of PR is this?

docs: Documentation only changes

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

补充 RequestContext 的Redirect 和Header 方法的注释,以 Gin 中对应的方法注释为模版,降低理解成本

(Optional) Which issue(s) this PR fixes:

#867

@Tom-debug110 Tom-debug110 requested review from a team as code owners July 23, 2023 13:53
@CLAassistant
Copy link

CLAassistant commented Jul 23, 2023

CLA assistant check
All committers have signed the CLA.

li-jin-gou
li-jin-gou previously approved these changes Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c0512ff) 81.82% compared to head (ca6f05a) 81.85%.
Report is 3 commits behind head on develop.

❗ Current head ca6f05a differs from pull request most recent head 2f739b5. Consider uploading reports for the commit 2f739b5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #868      +/-   ##
===========================================
+ Coverage    81.82%   81.85%   +0.03%     
===========================================
  Files           98       98              
  Lines         9926     9926              
===========================================
+ Hits          8122     8125       +3     
+ Misses        1314     1311       -3     
  Partials       490      490              
Files Coverage Δ
pkg/app/context.go 93.41% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/app/context.go Outdated Show resolved Hide resolved
@welkeyever welkeyever changed the title <docs>:add comment for method Redirect and Header in pkg/app/context.go docs: add comment for method Redirect and Header Aug 23, 2023
pkg/app/context.go Outdated Show resolved Hide resolved
pkg/app/context.go Outdated Show resolved Hide resolved
pkg/app/context.go Outdated Show resolved Hide resolved
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@li-jin-gou li-jin-gou merged commit f7a873f into cloudwego:develop Oct 17, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants