feat: add server DisableHeaderNamesNormalizing option #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-jin-gou
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #839 +/- ##
===========================================
- Coverage 80.30% 80.25% -0.05%
===========================================
Files 97 97
Lines 9602 9620 +18
===========================================
+ Hits 7711 7721 +10
- Misses 1408 1413 +5
- Partials 483 486 +3
☔ View full report in Codecov by Sentry. |
li-jin-gou
force-pushed
the
feat/add_disable_normalizing
branch
2 times, most recently
from
4835aac
to
6dc350f
Compare
li-jin-gou
force-pushed
the
feat/add_disable_normalizing
branch
from
6dc350f
to
e26d309
Compare
li-jin-gou
changed the title
welkeyever
reviewed
Aug 24, 2023
pkg/protocol/http1/server.go
Outdated
| @@ -179,6 +180,12 @@ func (s Server) Serve(c context.Context, conn network.Conn) (err error) { | |||
| internalStats.Record(ti, stats.ReadHeaderFinish, err) | |||
| }) | |||
| } | |||
|
|
|||
| if s.DisableHeaderNamesNormalizing { | |||
| ctx.Request.Header.DisableNormalizing() | |||
There was a problem hiding this comment.
可以统一放在ctx从池子初始化的地方做，这个应该是一个”只需做一次的配置“，放在这里会影响每一个请求。
另外这个配置需要区分req/resp吗？
There was a problem hiding this comment.
done，另外区分了 request 和 response 配置
There was a problem hiding this comment.
之前应该想的有问题，这个配置最终生效在ctx.Request.Header的field上，这个是一个每次请求结束都会被重置的字段，看起来应该只能是每次解析请求前配置一次
|
move to #940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
<type>(optional scope): <description>.(Optional) Translate the PR title into Chinese.
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: