Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(binding): use internal tagexpr #1234

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Nov 20, 2024

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

使用internal的tagexpr实现

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

* remove unused code in github.com/bytedance/go-tagexpr
* remove personal repos github.com/henrylee2cn/*

zh(optional):

* 去掉无用的 github.com/bytedance/go-tagexpr 代码
* 去掉个人仓库 github.com/henrylee2cn/*

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners November 20, 2024 09:17
github-actions[bot]

This comment was marked as resolved.

@welkeyever
Copy link
Member

@xiaost
Copy link
Contributor Author

xiaost commented Nov 20, 2024

@FGYFFFF @welkeyever 我故意分成了两个commit,第一个只是copy代码,第二个才是修改。这样知道变更了什么。

@xiaost xiaost force-pushed the refactor/new-tagexpr branch 2 times, most recently from e74d76b to a607728 Compare November 20, 2024 10:00
@cloudwego cloudwego deleted a comment from github-actions bot Nov 20, 2024
@cloudwego cloudwego deleted a comment from github-actions bot Nov 20, 2024
* remove unused code in github.com/bytedance/go-tagexpr
* remove personal repos github.com/henrylee2cn/*
@xiaost xiaost merged commit 7d63572 into develop Nov 22, 2024
35 checks passed
@xiaost xiaost deleted the refactor/new-tagexpr branch November 22, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants